linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kosaki.motohiro@jp.fujitsu.com,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	Wu Fengguang <fengguang.wu@intel.com>,
	Rik van Riel <riel@redhat.com>,
	Minchan Kim <minchan.kim@gmail.com>,
	Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [PATCH 3/3] add isolate pages vmstat
Date: Thu, 16 Jul 2009 13:35:07 +0900 (JST)	[thread overview]
Message-ID: <20090716132639.9D31.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <20090715201657.b01edccd.akpm@linux-foundation.org>

> > reproduce way
> > -----------------------
> > % ./hackbench 140 process 1000
> >    => OOM occur
> > 
> > active_anon:146 inactive_anon:0 isolated_anon:49245
> >  active_file:79 inactive_file:18 isolated_file:113
> >  unevictable:0 dirty:0 writeback:0 unstable:0 buffer:39
> >  free:370 slab_reclaimable:309 slab_unreclaimable:5492
> >  mapped:53 shmem:15 pagetables:28140 bounce:0
> > 
> > @@ -1164,6 +1170,9 @@ static unsigned long shrink_inactive_lis
> >  				spin_lock_irq(&zone->lru_lock);
> >  			}
> >  		}
> > +		__mod_zone_page_state(zone, NR_ISOLATED_ANON, -nr_anon);
> > +		__mod_zone_page_state(zone, NR_ISOLATED_FILE, -nr_file);
> > +
> >    	} while (nr_scanned < max_scan);
> 
> This is a non-trivial amount of extra stuff.  Do we really need it?

In general, Administrator really hate large amount unaccounted memory.
Recent msgctl11 discussion, We faced it isolate pages about 1/3 system 
memory.
Ahtough Rik's patch is applied, vmscan can isolate >1GB memory.

That's my point.





--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2009-07-16  4:35 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-16  0:51 [PATCH 0/3] Account the number of isolate pages KOSAKI Motohiro
2009-07-16  0:52 ` [PATCH 1/3] Rename pgmoved variable in shrink_active_list() KOSAKI Motohiro
2009-07-16  2:08   ` Rik van Riel
2009-07-16  3:16   ` Andrew Morton
2009-07-16  4:01     ` Minchan Kim
2009-07-16  4:22     ` KOSAKI Motohiro
2009-07-16  4:35       ` Andrew Morton
2009-07-16  4:38         ` KOSAKI Motohiro
2009-07-16  4:46           ` KOSAKI Motohiro
2009-07-16  4:49           ` Andrew Morton
2009-07-16  4:00   ` Minchan Kim
2009-07-16 12:33   ` Wu Fengguang
2009-07-16 14:11   ` Christoph Lameter
2009-07-16 17:32   ` Johannes Weiner
2009-07-17  5:43     ` KOSAKI Motohiro
2009-07-16  0:53 ` [PATCH 2/3] mm: shrink_inactive_lis() nr_scan accounting fix fix KOSAKI Motohiro
2009-07-16  2:10   ` Rik van Riel
2009-07-16  4:10   ` Minchan Kim
2009-07-16 12:55   ` Wu Fengguang
2009-07-17  0:16     ` KOSAKI Motohiro
2009-07-16  0:55 ` [PATCH 3/3] add isolate pages vmstat KOSAKI Motohiro
2009-07-16  3:16   ` Andrew Morton
2009-07-16  4:22     ` Minchan Kim
2009-07-16  4:35     ` KOSAKI Motohiro [this message]
2009-07-16 14:26   ` Christoph Lameter
2009-07-17  7:00     ` KOSAKI Motohiro
2009-07-17 16:34       ` Christoph Lameter
2009-07-20  5:39         ` KOSAKI Motohiro
2009-07-20 15:27           ` Christoph Lameter
2009-07-20 16:22             ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090716132639.9D31.A69D9226@jp.fujitsu.com \
    --to=kosaki.motohiro@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan.kim@gmail.com \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox