From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id E44836B0082 for ; Thu, 16 Jul 2009 00:49:23 -0400 (EDT) Date: Wed, 15 Jul 2009 21:49:23 -0700 From: Andrew Morton Subject: Re: [PATCH 1/3] Rename pgmoved variable in shrink_active_list() Message-Id: <20090715214923.d0f0cf51.akpm@linux-foundation.org> In-Reply-To: <20090716133622.9D34.A69D9226@jp.fujitsu.com> References: <20090716131928.9D25.A69D9226@jp.fujitsu.com> <20090715213516.9b47ad16.akpm@linux-foundation.org> <20090716133622.9D34.A69D9226@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: KOSAKI Motohiro Cc: LKML , linux-mm , Wu Fengguang , Rik van Riel , Minchan Kim , Christoph Lameter List-ID: On Thu, 16 Jul 2009 13:38:21 +0900 (JST) KOSAKI Motohiro wrote: > > On Thu, 16 Jul 2009 13:22:30 +0900 (JST) KOSAKI Motohiro wrote: > > > > > -#define __add_zone_page_state(__z, __i, __d) \ > > > - __mod_zone_page_state(__z, __i, __d) > > > -#define __sub_zone_page_state(__z, __i, __d) \ > > > - __mod_zone_page_state(__z, __i,-(__d)) > > > - > > > > yeah, whatever, I don't think they add a lot of value personally. > > > > I guess they're a _bit_ clearer than doing __sub_zone_page_state() with > > a negated argument. Shrug. > > OK, I've catched your point. I don't think I have a point ;) > I'll make all caller replacing patches. Well, if you guys think it's worth it, sure. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org