From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id 79FAA6B004F for ; Mon, 13 Jul 2009 02:38:13 -0400 (EDT) Date: Mon, 13 Jul 2009 08:59:17 +0200 From: Nick Piggin Subject: Re: [rfc][patch 3/4] fs: new truncate sequence Message-ID: <20090713065917.GO14666@wotan.suse.de> References: <20090707150758.GA18075@infradead.org> <20090707154809.GH2714@wotan.suse.de> <20090707163042.GA14947@infradead.org> <20090708063225.GL2714@wotan.suse.de> <20090708104701.GA31419@infradead.org> <20090708123412.GQ2714@wotan.suse.de> <4A54C435.1000503@panasas.com> <20090709075100.GU2714@wotan.suse.de> <4A59A517.1080605@panasas.com> <20090712144717.GA18163@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090712144717.GA18163@infradead.org> Sender: owner-linux-mm@kvack.org To: Christoph Hellwig Cc: Boaz Harrosh , linux-fsdevel@vger.kernel.org, Jan Kara , LKML , linux-mm@kvack.org List-ID: On Sun, Jul 12, 2009 at 10:47:18AM -0400, Christoph Hellwig wrote: > On Sun, Jul 12, 2009 at 11:55:51AM +0300, Boaz Harrosh wrote: > > I wish you would split it. > > > > one - helper to be called by converted file systems > > (Which just ignores the ATTR_SIZE) > > second - to be set into .setattr which does the simple_setsize + above. > > > > More clear for FS users like me (and that ugly unmask of ATTR_SIZE) > > > > or it's just me? > > Yeah, that seems be a lot cleaner. But let's wait until we got > rid of ->truncate for all filesystems to have the bigger picture. Agreed, if it is a common sequence / requirement for filesystems then of course I will not object to a helper to make things clearer or share code. I would like to see inode_setattr renamed into simple_setattr, and then also .setattr made mandatory, so I don't like to cut code out of inode_setattr which makes it unable to be the simple_setattr after the old truncate code is removed. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org