From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id 8E9176B005D for ; Mon, 6 Jul 2009 21:07:24 -0400 (EDT) Received: by pzk41 with SMTP id 41so3932257pzk.12 for ; Mon, 06 Jul 2009 18:48:16 -0700 (PDT) Date: Tue, 7 Jul 2009 10:48:06 +0900 From: Minchan Kim Subject: Re: [PATCH 4/5] add isolate pages vmstat Message-Id: <20090707104806.6706ac4a.minchan.kim@barrios-desktop> In-Reply-To: <20090707101855.0C63.A69D9226@jp.fujitsu.com> References: <20090707090120.1e71a060.minchan.kim@barrios-desktop> <20090707090509.0C60.A69D9226@jp.fujitsu.com> <20090707101855.0C63.A69D9226@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: KOSAKI Motohiro Cc: Minchan Kim , Wu Fengguang , LKML , linux-mm , Andrew Morton , Christoph Lameter , David Rientjes , Rik van Riel List-ID: It looks good to me. Thanks for your effort. I added my review sign. :) Let remain one side note. This accounting feature results from direct reclaim bomb. If we prevent direct reclaim bomb, I think this feature can be removed. As I know, Rik or Wu is making patch for throttling direct reclaim. On Tue, 7 Jul 2009 10:19:53 +0900 (JST) KOSAKI Motohiro wrote: > > > > Index: b/mm/vmscan.c > > > > =================================================================== > > > > --- a/mm/vmscan.c > > > > +++ b/mm/vmscan.c > > > > @@ -1082,6 +1082,7 @@ static unsigned long shrink_inactive_lis > > > > -count[LRU_ACTIVE_ANON]); > > > > __mod_zone_page_state(zone, NR_INACTIVE_ANON, > > > > -count[LRU_INACTIVE_ANON]); > > > > + __mod_zone_page_state(zone, NR_ISOLATED_ANON + file, nr_taken); > > > > > > Lumpy can reclaim file + anon anywhere. > > > How about using count[NR_LRU_LISTS]? > > > > Ah yes, good catch. > > Fixed. > > Subject: [PATCH] add isolate pages vmstat > > If the system have plenty threads or processes, concurrent reclaim can > isolate very much pages. > Unfortunately, current /proc/meminfo and OOM log can't show it. > > This patch provide the way of showing this information. > > > reproduce way > ----------------------- > % ./hackbench 140 process 1000 > => couse OOM > > Active_anon:146 active_file:41 inactive_anon:0 > inactive_file:0 unevictable:0 > isolated_anon:49245 isolated_file:113 > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > dirty:0 writeback:0 buffer:49 unstable:0 > free:184 slab_reclaimable:276 slab_unreclaimable:5492 > mapped:87 pagetables:28239 bounce:0 > > > Signed-off-by: KOSAKI Motohiro Reviewed-by: Minchan Kim -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org