From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: balbir@linux.vnet.ibm.com
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
"menage@google.com" <menage@google.com>
Subject: Re: [PATCH] memcg: fix cgroup rmdir hang v4
Date: Thu, 2 Jul 2009 15:35:45 +0900 [thread overview]
Message-ID: <20090702153545.15d313d6.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20090702063002.GO11273@balbir.in.ibm.com>
On Thu, 2 Jul 2009 12:00:05 +0530
Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> * KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> [2009-07-01 10:47:47]:
> > -static void cgroup_wakeup_rmdir_waiters(const struct cgroup *cgrp)
> > +static void cgroup_wakeup_rmdir_waiter(struct cgroup *cgrp)
>
> Should the function explictly mention rmdir?
For now, yes. this is only for rmdir.
> Also something like
> release_rmdir should be called release_and_wakeup to make the action
> clearer.
>
Hm, I don't think this name is too bad. Comment is enough and if we have to
change the behavior of cgroup-internal work, we have to rename this again.
This name is not too much explaining but showing enough information.
> Looks good to me otherwise and clean.
>
Thank you.
Regards,
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2009-07-02 6:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-30 9:01 [PATCH 0/2] memcg: fix cgroup rmdir hang v3 KAMEZAWA Hiroyuki
2009-06-30 9:02 ` [PATCH 1/2] " KAMEZAWA Hiroyuki
2009-06-30 9:03 ` [PATCH 2/2] cgroup: exlclude release rmdir KAMEZAWA Hiroyuki
2009-06-30 9:15 ` Paul Menage
2009-06-30 9:23 ` KAMEZAWA Hiroyuki
2009-06-30 16:18 ` Paul Menage
2009-06-30 23:40 ` Daisuke Nishimura
2009-07-01 0:09 ` KAMEZAWA Hiroyuki
2009-07-01 0:27 ` Paul Menage
2009-07-01 1:04 ` KAMEZAWA Hiroyuki
2009-07-01 18:17 ` Paul Menage
2009-07-02 1:27 ` Li Zefan
2009-07-01 1:47 ` [PATCH] memcg: fix cgroup rmdir hang v4 KAMEZAWA Hiroyuki
2009-07-01 15:57 ` Paul Menage
2009-07-01 23:35 ` Daisuke Nishimura
2009-07-02 6:30 ` Balbir Singh
2009-07-02 6:35 ` KAMEZAWA Hiroyuki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090702153545.15d313d6.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=menage@google.com \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox