From: Shaohua Li <shaohua.li@intel.com>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"mel@csn.ul.ie" <mel@csn.ul.ie>,
"Zhao, Yakui" <yakui.zhao@intel.com>
Subject: Re: + memory-hotplug-exclude-isolated-page-from-pco-page-alloc.patch added to -mm tree
Date: Tue, 30 Jun 2009 09:03:02 +0800 [thread overview]
Message-ID: <20090630010302.GD21254@sli10-desk.sh.intel.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0906291818460.21956@gentwo.org>
On Tue, Jun 30, 2009 at 06:20:00AM +0800, Christoph Lameter wrote:
> On Mon, 29 Jun 2009, akpm@linux-foundation.org wrote:
>
> > Pages marked as isolated should not be allocated again. If such pages
> > reside in pcp list, they can be allocated too, so there is a ping-pong
> > memory offline frees some pages to pcp list and the pages get allocated
> > and then memory offline frees them again, this loop will happen again and
> > again.
>
> Isolated pages are freed? Could they not be kept on a separate
> list with refcount elevated until the isolation procedure is complete?
Yes, they can be freed and add into pcp list. Moving them to a separate list
is feasible, but the approach is more intrusive to me. As I explained in the
patch, adding check in buffered_rmqueue() should hasn't impact for normal path.
Thanks,
Shaohua
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
parent reply other threads:[~2009-06-30 1:03 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <alpine.DEB.1.10.0906291818460.21956@gentwo.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090630010302.GD21254@sli10-desk.sh.intel.com \
--to=shaohua.li@intel.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox