linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky@mail.by>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
	Ingo Molnar <mingo@elte.hu>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: kmemleak suggestion (long message)
Date: Sat, 27 Jun 2009 01:48:02 +0300	[thread overview]
Message-ID: <20090626224802.GB3858@localdomain.by> (raw)
In-Reply-To: <1246032766.30717.44.camel@pc1117.cambridge.arm.com>

On (06/26/09 17:12), Catalin Marinas wrote:
> I had a look at your patch and I tend to agree with Pekka. It really
> adds too much complexity for something that could be easily done in user
> space (could be more concise or even written in perl, awk, sed, python
> etc.):
> 
> cat /sys/kernel/debug/kmemleak | tr "\n" "#" \
> 	| sed -e "s/#unreferenced/\nunreferenced/g" \
> 	| grep -v "tty_ldisc_try_get" | tr "#" "\n"
> 
Well, it's hardly can be compared with 
echo "block=ADDRESS_FROM_STACK" > /.../kmemleak

Frankly, I still found it useful (as you don't have to write in perl, awk, sed, python etc 
to see 50 lines (you are interested in) out of 1000.
You just watching reports.)

(well, maybe not as useful as with syslog.)
 
Anyway, the decision is yours. And let it be so.
Thanks.

> Thanks anyway.
> 
> -- 
> Catalin
> 

	Sergey

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-06-26 22:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-25 22:18 Sergey Senozhatsky
2009-06-26  6:59 ` Ingo Molnar
2009-06-26  7:07   ` Pekka Enberg
2009-06-26  8:14     ` Sergey Senozhatsky
2009-06-26  8:17       ` Pekka Enberg
2009-06-26  8:50         ` Sergey Senozhatsky
2009-06-26  8:54           ` Catalin Marinas
2009-06-26  9:13             ` Sergey Senozhatsky
2009-06-26  9:20             ` Alan Cox
2009-06-26 16:12           ` Catalin Marinas
2009-06-26 22:48             ` Sergey Senozhatsky [this message]
2009-06-26  7:48   ` Sergey Senozhatsky
2009-06-26  8:25   ` Catalin Marinas
2009-06-26  8:27     ` Pekka Enberg
2009-06-26  8:41       ` Catalin Marinas
2009-06-26  8:42       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090626224802.GB3858@localdomain.by \
    --to=sergey.senozhatsky@mail.by \
    --cc=akpm@linux-foundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@elte.hu \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox