From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: akataria@vmware.com, LKML <linux-kernel@vger.kernel.org>,
Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
Dave Hansen <dave@linux.vnet.ibm.com>, Mel Gorman <mel@csn.ul.ie>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH] Hugepages should be accounted as unevictable pages.
Date: Tue, 23 Jun 2009 14:11:47 +0900 [thread overview]
Message-ID: <20090623141147.8f2cef18.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20090623135017.220D.A69D9226@jp.fujitsu.com>
On Tue, 23 Jun 2009 14:05:47 +0900 (JST)
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> I'm not sure this unevictable definition is good idea or not. currently
> hugepage isn't only non-account memory, but also various kernel memory doesn't
> account.
>
> one of drawback is that zone_page_state(UNEVICTABLE) lost to mean #-of-unevictable-pages.
> e.g. following patch is wrong?
>
> fs/proc/meminfo.c meminfo_proc_show()
> ----------------------------
> - K(pages[LRU_UNEVICTABLE]),
> + K(pages[LRU_UNEVICTABLE]) + hstate->nr_huge_pages,
>
>
> Plus, I didn't find any practical benefit in this patch. do you have it?
> or You only want to natural definition?
>
> I don't have any strong oppose reason, but I also don't have any strong
> agree reason.
>
I think "don't include Hugepage" is sane. Hugepage is something _special_, now.
Thanks,
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-06-23 5:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 21:25 Alok Kataria
2009-06-23 3:25 ` KOSAKI Motohiro
2009-06-23 4:46 ` Alok Kataria
2009-06-23 5:05 ` KOSAKI Motohiro
2009-06-23 5:11 ` KAMEZAWA Hiroyuki [this message]
2009-06-23 5:54 ` Alok Kataria
2009-06-23 6:06 ` KAMEZAWA Hiroyuki
2009-06-23 19:28 ` Alok Kataria
2009-06-23 20:30 ` Lee Schermerhorn
2009-06-23 21:24 ` Rik van Riel
2009-06-23 21:42 ` Alok Kataria
2009-06-23 21:55 ` Rik van Riel
2009-06-23 22:06 ` Alok Kataria
2009-06-23 22:19 ` Dave Hansen
2009-06-23 22:55 ` Rik van Riel
2009-06-23 23:28 ` Alok Kataria
2009-06-23 23:48 ` Dave Hansen
2009-06-23 22:15 ` Dave Hansen
2009-06-23 22:23 ` Alok Kataria
2009-06-23 23:41 ` Dave Hansen
2009-06-24 0:08 ` Alok Kataria
2009-06-23 12:26 ` Lee Schermerhorn
2009-06-29 9:58 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090623141147.8f2cef18.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=Lee.Schermerhorn@hp.com \
--cc=akataria@vmware.com \
--cc=dave@linux.vnet.ibm.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox