From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id E5A6A6B004F for ; Mon, 22 Jun 2009 19:57:42 -0400 (EDT) Received: from m2.gw.fujitsu.co.jp ([10.0.50.72]) by fgwmail5.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id n5MNxU4M009916 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Tue, 23 Jun 2009 08:59:31 +0900 Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 5D3A445DE62 for ; Tue, 23 Jun 2009 08:59:30 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id DFD7245DE57 for ; Tue, 23 Jun 2009 08:59:29 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id BAB851DB803A for ; Tue, 23 Jun 2009 08:59:29 +0900 (JST) Received: from ml14.s.css.fujitsu.com (ml14.s.css.fujitsu.com [10.249.87.104]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 3631B1DB8040 for ; Tue, 23 Jun 2009 08:59:29 +0900 (JST) Date: Tue, 23 Jun 2009 08:57:55 +0900 From: KAMEZAWA Hiroyuki Subject: [BUGFIX][PATCH] fix bad page removal from LRU (Was Re: [RFC][PATCH] cgroup: fix permanent wait in rmdir Message-Id: <20090623085755.9cf75da2.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20090622105231.GA17242@elte.hu> References: <20090622183707.dd9e665b.kamezawa.hiroyu@jp.fujitsu.com> <20090622105231.GA17242@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Ingo Molnar Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "balbir@linux.vnet.ibm.com" , "nishimura@mxp.nes.nec.co.jp" , "menage@google.com" , "akpm@linux-foundation.org" List-ID: On Mon, 22 Jun 2009 12:52:31 +0200 Ingo Molnar wrote: > > FYI, there's a new cgroup related list corruption warning/crash that > i've seen a lot of times in latest -tip tests: > > [ 478.555544] ------------[ cut here ]------------ > [ 478.556523] WARNING: at lib/list_debug.c:26 __list_add+0x70/0xa0() > [ 478.556523] Hardware name: > [ 478.556523] list_add corruption. next->prev should be prev (ffff88003e640448), but was ffff88003fa1a6e8. (next=ffff88003fa1a8a0). > [ 478.556523] Modules linked in: > [ 478.556523] Pid: 470, comm: kswapd0 Not tainted 2.6.30-tip #10989 > [ 478.556523] Call Trace: > [ 478.556523] [] ? __list_add+0x70/0xa0 > [ 478.556523] [] warn_slowpath_common+0x8c/0xc0 > [ 478.556523] [] warn_slowpath_fmt+0x69/0x70 > [ 478.556523] [] ? __lock_acquired+0x18b/0x2b0 > [ 478.556523] [] ? page_check_address+0x110/0x1a0 > [ 478.556523] [] ? cpumask_any_but+0x42/0xb0 > [ 478.556523] [] ? __lock_release+0x38/0x90 > [ 478.556523] [] ? page_referenced_one+0x91/0x120 > [ 478.556523] [] __list_add+0x70/0xa0 > [ 478.556523] [] mem_cgroup_add_lru_list+0x63/0x70 > [ 478.556523] [] move_active_pages_to_lru+0xf4/0x180 > [ 478.556523] [] ? shrink_active_list+0x1f8/0x2a0 > [ 478.556523] [] ? shrink_active_list+0x1f8/0x2a0 > [ 478.556523] [] shrink_active_list+0x234/0x2a0 > [ 478.556523] [] shrink_zone+0x173/0x1f0 > [ 478.556523] [] balance_pgdat+0x4da/0x4e0 > [ 478.556523] [] ? isolate_pages_global+0x0/0x60 > [ 478.556523] [] kswapd+0x106/0x150 > [ 478.556523] [] ? autoremove_wake_function+0x0/0x40 > [ 478.556523] [] ? kswapd+0x0/0x150 > [ 478.556523] [] kthread+0x9e/0xb0 > [ 478.556523] [] child_rip+0xa/0x20 > [ 478.556523] [] ? restore_args+0x0/0x30 > [ 478.556523] [] ? kthreadd+0xb5/0x100 > [ 478.556523] [] ? kthread+0x0/0xb0 > [ 478.556523] [] ? child_rip+0x0/0x20 > [ 478.556523] ---[ end trace 9f3122957c34141e ]--- > [ 484.923530] ------------[ cut here ]------------ > [ 484.924525] WARNING: at lib/list_debug.c:26 __list_add+0x70/0xa0() > [ 484.924525] Hardware name: > [ 484.924525] list_add corruption. next->prev should be prev (ffff88003e640448), but was ffff88003fa192e8. (next=ffff88003fa14d88). > [ 484.941152] Modules linked in: > [ 484.941152] Pid: 470, comm: kswapd0 Tainted: G W 2.6.30-tip #10989 > [ 484.941152] Call Trace: > [ 484.941152] [] ? __list_add+0x70/0xa0 > [ 484.941152] [] warn_slowpath_common+0x8c/0xc0 > [ 484.941152] [] warn_slowpath_fmt+0x69/0x70 > [ 484.941152] [] ? __lock_acquired+0x18b/0x2b0 > [ 484.941152] [] ? page_check_address+0x110/0x1a0 > [ 484.941152] [] ? cpumask_any_but+0x42/0xb0 > [ 484.941152] [] ? __lock_release+0x38/0x90 > [ 484.941152] [] ? page_referenced_one+0x91/0x120 > [ 484.941152] [] __list_add+0x70/0xa0 > [ 484.941152] [] mem_cgroup_add_lru_list+0x63/0x70 > [ 484.941152] [] move_active_pages_to_lru+0xf4/0x180 > [ 484.941152] [] ? shrink_active_list+0x1f8/0x2a0 > [ 484.941152] [] ? shrink_active_list+0x1f8/0x2a0 > [ 484.941152] [] shrink_active_list+0x234/0x2a0 > [ 484.941152] [] shrink_zone+0x173/0x1f0 > [ 484.941152] [] balance_pgdat+0x4da/0x4e0 > [ 484.941152] [] ? isolate_pages_global+0x0/0x60 > [ 484.941152] [] kswapd+0x106/0x150 > [ 484.941152] [] ? autoremove_wake_function+0x0/0x40 > [ 484.941152] [] ? kswapd+0x0/0x150 > [ 484.941152] [] kthread+0x9e/0xb0 > [ 484.941152] [] child_rip+0xa/0x20 > [ 484.941152] [] ? restore_args+0x0/0x30 > [ 484.941152] [] ? kthreadd+0xb5/0x100 > [ 484.941152] [] ? kthread+0x0/0xb0 > [ 484.941152] [] ? child_rip+0x0/0x20 > [ 484.941152] ---[ end trace 9f3122957c34141f ]--- > [ 485.365631] ------------[ cut here ]------------ > [ 485.368029] WARNING: at lib/list_debug.c:26 __list_add+0x70/0xa0() > > has this been reported before? Is there a fix for it i missed? > I think this is a fix for the problem. Sorry for regression. fix for "memcg: fix lru rotation in isolate_pages" patch in 2.6.30-git18. == From: KAMEZAWA Hiroyuki A page isolated is "cursor_page" not "page". This causes list corruption finally. Signed-off-by: KAMEZAWA Hiroyuki --- mm/vmscan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.30-git18/mm/vmscan.c =================================================================== --- linux-2.6.30-git18.orig/mm/vmscan.c +++ linux-2.6.30-git18/mm/vmscan.c @@ -932,7 +932,7 @@ static unsigned long isolate_lru_pages(u continue; if (__isolate_lru_page(cursor_page, mode, file) == 0) { list_move(&cursor_page->lru, dst); - mem_cgroup_del_lru(page); + mem_cgroup_del_lru(cursor_page); nr_taken++; scan++; } -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org