From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: kosaki.motohiro@jp.fujitsu.com,
Maxim Levitsky <maximlevitsky@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Mel Gorman <mel@csn.ul.ie>,
Andrew Morton <akpm@linux-foundation.org>,
Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
Christoph Lameter <cl@linux-foundation.org>,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: BUG: Bad page state [was: Strange oopses in 2.6.30]
Date: Mon, 22 Jun 2009 11:39:53 +0900 (JST) [thread overview]
Message-ID: <20090622113652.21E7.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <4A3CFFEC.1000805@gmail.com>
(cc to Mel and some reviewer)
> Flags are:
> 0000000000400000 -- __PG_MLOCKED
> 800000000050000c -- my page flags
> 3650000c -- Maxim's page flags
> 0000000000693ce1 -- my PAGE_FLAGS_CHECK_AT_FREE
I guess commit da456f14d (page allocator: do not disable interrupts in
free_page_mlock()) is a bit wrong.
current code is:
-------------------------------------------------------------
static void free_hot_cold_page(struct page *page, int cold)
{
(snip)
int clearMlocked = PageMlocked(page);
(snip)
if (free_pages_check(page))
return;
(snip)
local_irq_save(flags);
if (unlikely(clearMlocked))
free_page_mlock(page);
-------------------------------------------------------------
Oh well, we remove PG_Mlocked *after* free_pages_check().
Then, it makes false-positive warning.
Sorry, my review was also wrong. I think reverting this patch is better ;)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-06-22 2:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1245448091.5475.19.camel@localhost>
[not found] ` <1245506908.6327.36.camel@localhost>
2009-06-20 15:27 ` Jiri Slaby
2009-06-20 15:44 ` Maxim Levitsky
2009-06-22 2:39 ` KOSAKI Motohiro [this message]
2009-06-22 7:42 ` Pekka Enberg
2009-06-22 20:55 ` Mel Gorman
2009-06-22 9:16 ` Mel Gorman
2009-06-22 16:02 ` Lee Schermerhorn
2009-06-22 20:53 ` Mel Gorman
2009-06-23 11:11 ` KOSAKI Motohiro
2009-06-29 8:41 ` Mel Gorman
2009-06-29 10:18 ` Johannes Weiner
2009-06-29 10:37 ` Mel Gorman
2009-06-30 0:31 ` KOSAKI Motohiro
2009-06-30 15:11 ` Mel Gorman
2009-06-30 16:34 ` Mel Gorman
2009-06-30 23:45 ` KOSAKI Motohiro
2009-06-23 11:04 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090622113652.21E7.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=Lee.Schermerhorn@hp.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maximlevitsky@gmail.com \
--cc=mel@csn.ul.ie \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox