From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with ESMTP id 84EBF6B0062 for ; Wed, 17 Jun 2009 08:03:45 -0400 (EDT) Date: Wed, 17 Jun 2009 13:03:42 +0100 From: Mel Gorman Subject: Re: [PATCH 0/3] Fix malloc() stall in zone_reclaim() and bring behaviour more in line with expectations V3 Message-ID: <20090617120342.GB28529@csn.ul.ie> References: <20090616134423.GD14241@csn.ul.ie> <20090617190204.99C6.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20090617190204.99C6.A69D9226@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org To: KOSAKI Motohiro Cc: Christoph Lameter , Andrew Morton , riel@redhat.com, fengguang.wu@intel.com, linuxram@us.ibm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner List-ID: On Wed, Jun 17, 2009 at 07:06:46PM +0900, KOSAKI Motohiro wrote: > > On Tue, 16 Jun 2009, Mel Gorman wrote: > > > > > I don't have a particular workload in mind to be perfectly honest. I'm just not > > > convinced of the wisdom of trying to unmap pages by default in zone_reclaim() > > > just because the NUMA distances happen to be large. > > > > zone reclaim = 1 is supposed to be light weight with minimal impact. The > > intend was just to remove potentially unused pagecache pages so that node > > local allocations can succeed again. So lets not unmap pages. > > hm, At least major two zone reclaim developer disagree my patch. Thus I have to > agree with you, because I really don't hope to ignore other developer's opnion. > > So, as far as I understand, the conclusion of this thread are > - Drop my patch > - instead, implement improvement patch of (may_unmap && page_mapped()) case > - the documentation should be changed > - it's my homework(?) > > Can you agree this? > Yes. -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org