From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with SMTP id 8F3606B0055 for ; Thu, 11 Jun 2009 04:43:28 -0400 (EDT) Received: from m5.gw.fujitsu.co.jp ([10.0.50.75]) by fgwmail6.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id n5B8in2j017779 for (envelope-from kosaki.motohiro@jp.fujitsu.com); Thu, 11 Jun 2009 17:44:49 +0900 Received: from smail (m5 [127.0.0.1]) by outgoing.m5.gw.fujitsu.co.jp (Postfix) with ESMTP id 72F6E45DE53 for ; Thu, 11 Jun 2009 17:44:49 +0900 (JST) Received: from s5.gw.fujitsu.co.jp (s5.gw.fujitsu.co.jp [10.0.50.95]) by m5.gw.fujitsu.co.jp (Postfix) with ESMTP id 45B5F45DE4F for ; Thu, 11 Jun 2009 17:44:49 +0900 (JST) Received: from s5.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s5.gw.fujitsu.co.jp (Postfix) with ESMTP id 2AF561DB8038 for ; Thu, 11 Jun 2009 17:44:49 +0900 (JST) Received: from ml13.s.css.fujitsu.com (ml13.s.css.fujitsu.com [10.249.87.103]) by s5.gw.fujitsu.co.jp (Postfix) with ESMTP id DE67D1DB8043 for ; Thu, 11 Jun 2009 17:44:48 +0900 (JST) From: KOSAKI Motohiro Subject: Re: [PATCH 2/3] check unevictable flag in lumy reclaim v2 In-Reply-To: <20090611173819.0f76e431.kamezawa.hiroyu@jp.fujitsu.com> References: <20090611172249.6D3C.A69D9226@jp.fujitsu.com> <20090611173819.0f76e431.kamezawa.hiroyu@jp.fujitsu.com> Message-Id: <20090611174420.6D42.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Date: Thu, 11 Jun 2009 17:44:47 +0900 (JST) Sender: owner-linux-mm@kvack.org To: KAMEZAWA Hiroyuki Cc: kosaki.motohiro@jp.fujitsu.com, "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "nishimura@mxp.nes.nec.co.jp" , "balbir@linux.vnet.ibm.com" , "akpm@linux-foundation.org" , apw@canonical.com, riel@redhat.com, minchan.kim@gmail.com, mel@csn.ul.ie List-ID: > How about this ? > > From: KAMEZAWA Hiroyuki > > Lumpy reclaim check pages from their pfn. Then, it can find unevictable pages > in its loop. > Abort lumpy reclaim when we find Unevictable page, we never get a lump > of pages for requested order. > > Changelog: v1->v2 > - rewrote commet. Great. Reviewed-by: KOSAKI Motohiro > > Signed-off-by: KAMEZAWA Hiroyuki > --- > mm/vmscan.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > Index: lumpy-reclaim-trial/mm/vmscan.c > =================================================================== > --- lumpy-reclaim-trial.orig/mm/vmscan.c > +++ lumpy-reclaim-trial/mm/vmscan.c > @@ -936,6 +936,15 @@ static unsigned long isolate_lru_pages(u > /* Check that we have not crossed a zone boundary. */ > if (unlikely(page_zone_id(cursor_page) != zone_id)) > continue; > + /* > + * We tries to free all pages in this range to create > + * a free large page. Then, if the range includes a page > + * never be reclaimed, we have no reason to do more. > + * PageUnevictable page is not a page which can be > + * easily freed. Abort this scan now. > + */ > + if (unlikely(PageUnevictable(cursor_page))) > + break; > if (__isolate_lru_page(cursor_page, mode, file) == 0) { > list_move(&cursor_page->lru, dst); > nr_taken++; > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org