linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
	"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	apw@canonical.com, riel@redhat.com, minchan.kim@gmail.com,
	mel@csn.ul.ie
Subject: [PATCH 2/3] check unevictable flag in lumy reclaim v2
Date: Thu, 11 Jun 2009 17:38:19 +0900	[thread overview]
Message-ID: <20090611173819.0f76e431.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20090611172249.6D3C.A69D9226@jp.fujitsu.com>

How about this ?

From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

Lumpy reclaim check pages from their pfn. Then, it can find unevictable pages
in its loop.
Abort lumpy reclaim when we find Unevictable page, we never get a lump
of pages for requested order.

Changelog: v1->v2
 - rewrote commet.

Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
---
 mm/vmscan.c |    9 +++++++++
 1 file changed, 9 insertions(+)

Index: lumpy-reclaim-trial/mm/vmscan.c
===================================================================
--- lumpy-reclaim-trial.orig/mm/vmscan.c
+++ lumpy-reclaim-trial/mm/vmscan.c
@@ -936,6 +936,15 @@ static unsigned long isolate_lru_pages(u
 			/* Check that we have not crossed a zone boundary. */
 			if (unlikely(page_zone_id(cursor_page) != zone_id))
 				continue;
+			/*
+			 * We tries to free all pages in this range to create
+			 * a free large page. Then, if the range includes a page
+			 * never be reclaimed, we have no reason to do more.
+			 * PageUnevictable page is not a page which can be
+			 * easily freed. Abort this scan now.
+			 */
+			if (unlikely(PageUnevictable(cursor_page)))
+				break;
 			if (__isolate_lru_page(cursor_page, mode, file) == 0) {
 				list_move(&cursor_page->lru, dst);
 				nr_taken++;

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-06-11  8:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-11  7:55 [PATCH 0/3] misc fix around vmscan/isolate_lru_pages KAMEZAWA Hiroyuki
2009-06-11  8:00 ` [PATCH 1/3] remove wrong rotation at lumpy reclaim KAMEZAWA Hiroyuki
2009-06-11  8:21   ` KOSAKI Motohiro
2009-06-11  9:18   ` Minchan Kim
2009-06-11 11:13     ` KAMEZAWA Hiroyuki
2009-06-11 11:20       ` Minchan Kim
2009-06-11 22:52     ` Minchan Kim
2009-06-11 15:06   ` Mel Gorman
2009-06-11  8:01 ` [PATCH 2/3] check unevictable flag in lumy reclaim KAMEZAWA Hiroyuki
2009-06-11  8:24   ` KOSAKI Motohiro
2009-06-11  8:38     ` KAMEZAWA Hiroyuki [this message]
2009-06-11  8:44       ` [PATCH 2/3] check unevictable flag in lumy reclaim v2 KOSAKI Motohiro
2009-06-11  9:37       ` Minchan Kim
2009-06-11  9:39         ` Minchan Kim
2009-06-11 11:19         ` KAMEZAWA Hiroyuki
2009-06-11 11:59           ` Minchan Kim
2009-06-11 12:18             ` KAMEZAWA Hiroyuki
2009-06-11 22:55               ` Minchan Kim
2009-06-11 15:07   ` [PATCH 2/3] check unevictable flag in lumy reclaim Mel Gorman
2009-06-11  8:04 ` [PATCH 3/3] memcg: fix LRU rotation of isolate_lru_pages with memcg KAMEZAWA Hiroyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090611173819.0f76e431.kamezawa.hiroyu@jp.fujitsu.com \
    --to=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=minchan.kim@gmail.com \
    --cc=nishimura@mxp.nes.nec.co.jp \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox