From: Mel Gorman <mel@csn.ul.ie>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Rik van Riel <riel@redhat.com>,
Christoph Lameter <cl@linux-foundation.org>,
yanmin.zhang@intel.com, Wu Fengguang <fengguang.wu@intel.com>,
linuxram@us.ibm.com, linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] Count the number of times zone_reclaim() scans and fails
Date: Wed, 10 Jun 2009 11:36:22 +0100 [thread overview]
Message-ID: <20090610103622.GI25943@csn.ul.ie> (raw)
In-Reply-To: <20090610104635.DDA6.A69D9226@jp.fujitsu.com>
On Wed, Jun 10, 2009 at 10:47:20AM +0900, KOSAKI Motohiro wrote:
> Hi
>
> I like this patch. thank you mel.
>
> > @@ -2489,6 +2489,10 @@ int zone_reclaim(struct zone *zone, gfp_t gfp_mask, unsigned int order)
> > ret = __zone_reclaim(zone, gfp_mask, order);
> > zone_clear_flag(zone, ZONE_RECLAIM_LOCKED);
> >
> > + if (!ret) {
> > + count_vm_events(PGSCAN_ZONERECLAIM_FAILED, 1);
> > + }
> > +
> > return ret;
>
> count_vm_event(PGSCAN_ZONERECLAIM_FAILED)?
>
/me slaps self
Yes, that makes more sense.
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-06-10 10:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 17:01 [PATCH 0/4] [RFC] Functional fix to zone_reclaim() and bring behaviour more in line with expectations V2 Mel Gorman
2009-06-09 17:01 ` [PATCH 1/4] Properly account for the number of page cache pages zone_reclaim() can reclaim Mel Gorman
2009-06-09 18:15 ` Rik van Riel
2009-06-10 1:19 ` Wu Fengguang
2009-06-10 7:31 ` KOSAKI Motohiro
2009-06-10 10:31 ` Mel Gorman
2009-06-10 11:59 ` Wu Fengguang
2009-06-10 13:41 ` Mel Gorman
2009-06-10 22:42 ` Ram Pai
2009-06-11 13:52 ` Mel Gorman
2009-06-11 1:29 ` Wu Fengguang
2009-06-11 3:26 ` KOSAKI Motohiro
2009-06-09 17:01 ` [PATCH 2/4] Do not unconditionally treat zones that fail zone_reclaim() as full Mel Gorman
2009-06-09 18:11 ` Rik van Riel
2009-06-10 1:52 ` KOSAKI Motohiro
2009-06-09 17:01 ` [PATCH 3/4] Count the number of times zone_reclaim() scans and fails Mel Gorman
2009-06-09 18:56 ` Rik van Riel
2009-06-10 1:47 ` KOSAKI Motohiro
2009-06-10 10:36 ` Mel Gorman [this message]
2009-06-10 2:10 ` Wu Fengguang
2009-06-10 10:40 ` Mel Gorman
2009-06-09 17:01 ` [PATCH 4/4] Reintroduce zone_reclaim_interval for when zone_reclaim() scans and fails to avoid CPU spinning at 100% on NUMA Mel Gorman
2009-06-10 1:53 ` KOSAKI Motohiro
2009-06-10 5:54 ` Andrew Morton
2009-06-10 10:48 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090610103622.GI25943@csn.ul.ie \
--to=mel@csn.ul.ie \
--cc=cl@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxram@us.ibm.com \
--cc=riel@redhat.com \
--cc=yanmin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox