linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: "linux-mm@kvack.org" <linux-mm@kvack.org>
Cc: "kosaki.motohiro@jp.fujitsu.com" <kosaki.motohiro@jp.fujitsu.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	riel@redhat.com
Subject: [BUGFIX][PATCH] fix wrong lru rotate back at lumpty reclaim
Date: Tue, 9 Jun 2009 18:15:05 +0900	[thread overview]
Message-ID: <20090609181505.4083a213.kamezawa.hiroyu@jp.fujitsu.com> (raw)


From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

In lumpty reclaim, "cursor_page" is found just by pfn. Then, we don't know
from which LRU "cursor" page came from. Then, putback it to "src" list is BUG.
Just leave it as it is.
(And I think rotate here is overkilling even if "src" is correct.)

Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
---
 mm/vmscan.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Index: mmotm-2.6.30-Jun4/mm/vmscan.c
===================================================================
--- mmotm-2.6.30-Jun4.orig/mm/vmscan.c
+++ mmotm-2.6.30-Jun4/mm/vmscan.c
@@ -940,10 +940,9 @@ static unsigned long isolate_lru_pages(u
 				nr_taken++;
 				scan++;
 				break;
-
 			case -EBUSY:
-				/* else it is being freed elsewhere */
-				list_move(&cursor_page->lru, src);
+				/* Do nothing because we don't know where
+ 				   cusrsor_page comes from */
 			default:
 				break;	/* ! on LRU or wrong list */
 			}

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2009-06-09  8:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-09  9:15 KAMEZAWA Hiroyuki [this message]
2009-06-09  9:22 ` [PATCH] memcg: fix mem_cgroup_isolate_lru_page to use the same rotate logic at busy path KAMEZAWA Hiroyuki
2009-06-09 12:04   ` Balbir Singh
2009-06-09 23:58   ` Daisuke Nishimura
2009-06-09  9:29 ` [BUGFIX][PATCH] fix wrong lru rotate back at lumpty reclaim KOSAKI Motohiro
2009-06-09 10:00 ` Minchan Kim
2009-06-09 11:20   ` KAMEZAWA Hiroyuki
2009-06-09 11:30     ` Minchan Kim
2009-06-09 11:47       ` KAMEZAWA Hiroyuki
2009-06-09 12:07         ` Minchan Kim
2009-06-09 13:00           ` Andy Whitcroft
2009-06-09 14:01             ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090609181505.4083a213.kamezawa.hiroyu@jp.fujitsu.com \
    --to=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox