From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: kosaki.motohiro@jp.fujitsu.com,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH mmotm] vmscan: handle may_swap more strictly (Re: [PATCH mmotm] vmscan: fix may_swap handling for memcg)
Date: Tue, 9 Jun 2009 16:58:36 +0900 (JST) [thread overview]
Message-ID: <20090609164850.DD73.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <28c262360906090048x792fb3f9i6678298b693f6c5a@mail.gmail.com>
> Hi, KOSAKI.
>
> As you know, this problem caused by if condition(priority) in shrink_zone.
> Let me have a question.
>
> Why do we have to prevent scan value calculation when the priority is zero ?
> As I know, before split-lru, we didn't do it.
>
> Is there any specific issue in case of the priority is zero ?
Yes.
example:
get_scan_ratio() return anon:80%, file=20%. and the system have
10000 anon pages and 10000 file pages.
shrink_zone() picked up 8000 anon pages and 2000 file pages.
it mean 8000 file pages aren't scanned at all.
Oops, it can makes OOM-killer although system have droppable file cache.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-06-09 7:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-08 3:02 [PATCH mmotm] vmscan: fix may_swap handling for memcg Daisuke Nishimura
2009-06-08 3:20 ` KOSAKI Motohiro
2009-06-08 6:39 ` Daisuke Nishimura
2009-06-08 6:53 ` KOSAKI Motohiro
2009-06-08 7:54 ` Daisuke Nishimura
2009-06-09 7:13 ` [PATCH mmotm] vmscan: handle may_swap more strictly (Re: [PATCH mmotm] vmscan: fix may_swap handling for memcg) Daisuke Nishimura
2009-06-09 7:20 ` KOSAKI Motohiro
2009-06-09 7:48 ` Minchan Kim
2009-06-09 7:58 ` KOSAKI Motohiro [this message]
2009-06-09 8:19 ` Minchan Kim
2009-06-09 8:24 ` KOSAKI Motohiro
2009-06-09 8:35 ` Minchan Kim
2009-06-09 8:37 ` KOSAKI Motohiro
2009-06-09 7:28 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090609164850.DD73.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox