linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jack Steiner <steiner@sgi.com>
Cc: tglx@linutronix.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86, UV: Fix nacros for multiple coherency domains
Date: Mon, 8 Jun 2009 18:03:24 +0200	[thread overview]
Message-ID: <20090608160324.GA4355@elte.hu> (raw)
In-Reply-To: <20090608154405.GA16395@sgi.com>


* Jack Steiner <steiner@sgi.com> wrote:

> Fix bug in the SGI UV macros that support systems with multiple 
> coherency domains.  The macros used for referencing global MMR 
> (chipset registers) are failing to correctly "or" the NASID (node 
> identifier) bits that reside above M+N. These high bits are 
> supplied automatically by the chipset for memory accesses coming 
> from the processor socket. However, the bits must be present for 
> references to the special global MMR space used to map chipset 
> registers. (See uv_hub.h for more details ...)
> 
> The bug results in references to invalid/incorrect nodes.
> 
> Signed-off-by: Jack Steiner <steiner@sgi.com>
> 
> ---
>  arch/x86/include/asm/uv/uv_hub.h   |    6 ++++--
>  arch/x86/kernel/apic/x2apic_uv_x.c |   15 +++++++++------
>  2 files changed, 13 insertions(+), 8 deletions(-)

Applied, thanks Jack. Note - this has missed .30 but i marked it for 
.30.1 backporting, because it obviously only affects UV code.

	Ingo

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2009-06-08 14:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-08 15:44 Jack Steiner
2009-06-08 16:03 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090608160324.GA4355@elte.hu \
    --to=mingo@elte.hu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=steiner@sgi.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox