From: Andi Kleen <andi@firstfloor.org>
To: npiggin@suse.de, akpm@linux-foundation.orgnpiggin@suse.de,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
fengguang.wu@intel.com
Subject: [PATCH] [11/15] HWPOISON: Refactor truncate to allow direct truncating of page v2
Date: Thu, 4 Jun 2009 23:28:23 +0200 (CEST) [thread overview]
Message-ID: <20090604212823.16F901D0293@basil.firstfloor.org> (raw)
In-Reply-To: <200906041128.112757038@firstfloor.org>
From: Nick Piggin <npiggin@suse.de>
Extract out truncate_inode_page() out of the truncate path so that
it can be used by memory-failure.c
[AK: description, headers, fix typos]
v2: Some white space changes from Fengguang Wu
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
include/linux/mm.h | 2 ++
mm/truncate.c | 24 ++++++++++++------------
2 files changed, 14 insertions(+), 12 deletions(-)
Index: linux/mm/truncate.c
===================================================================
--- linux.orig/mm/truncate.c
+++ linux/mm/truncate.c
@@ -135,6 +135,16 @@ invalidate_complete_page(struct address_
return ret;
}
+void truncate_inode_page(struct address_space *mapping, struct page *page)
+{
+ if (page_mapped(page)) {
+ unmap_mapping_range(mapping,
+ (loff_t)page->index << PAGE_CACHE_SHIFT,
+ PAGE_CACHE_SIZE, 0);
+ }
+ truncate_complete_page(mapping, page);
+}
+
/**
* truncate_inode_pages - truncate range of pages specified by start & end byte offsets
* @mapping: mapping to truncate
@@ -196,12 +206,7 @@ void truncate_inode_pages_range(struct a
unlock_page(page);
continue;
}
- if (page_mapped(page)) {
- unmap_mapping_range(mapping,
- (loff_t)page_index<<PAGE_CACHE_SHIFT,
- PAGE_CACHE_SIZE, 0);
- }
- truncate_complete_page(mapping, page);
+ truncate_inode_page(mapping, page);
unlock_page(page);
}
pagevec_release(&pvec);
@@ -238,15 +243,10 @@ void truncate_inode_pages_range(struct a
break;
lock_page(page);
wait_on_page_writeback(page);
- if (page_mapped(page)) {
- unmap_mapping_range(mapping,
- (loff_t)page->index<<PAGE_CACHE_SHIFT,
- PAGE_CACHE_SIZE, 0);
- }
+ truncate_inode_page(mapping, page);
if (page->index > next)
next = page->index;
next++;
- truncate_complete_page(mapping, page);
unlock_page(page);
}
pagevec_release(&pvec);
Index: linux/include/linux/mm.h
===================================================================
--- linux.orig/include/linux/mm.h
+++ linux/include/linux/mm.h
@@ -811,6 +811,8 @@ static inline void unmap_shared_mapping_
extern int vmtruncate(struct inode * inode, loff_t offset);
extern int vmtruncate_range(struct inode * inode, loff_t offset, loff_t end);
+void truncate_inode_page(struct address_space *mapping, struct page *page);
+
#ifdef CONFIG_MMU
extern int handle_mm_fault(struct mm_struct *mm, struct vm_area_struct *vma,
unsigned long address, int write_access);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-06-04 21:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 21:28 [PATCH] [0/15] HWPOISON: Intro Andi Kleen
2009-06-04 21:28 ` [PATCH] [1/15] HWPOISON: Add page flag for poisoned pages Andi Kleen
2009-06-04 21:28 ` [PATCH] [2/15] HWPOISON: Export some rmap vma locking to outside world Andi Kleen
2009-06-04 21:28 ` [PATCH] [3/15] HWPOISON: Add support for poison swap entries v2 Andi Kleen
2009-06-04 21:28 ` [PATCH] [4/15] HWPOISON: Add new SIGBUS error codes for hardware poison signals Andi Kleen
2009-06-04 21:28 ` [PATCH] [5/15] HWPOISON: Add basic support for poisoned pages in fault handler v3 Andi Kleen
2009-06-04 21:28 ` [PATCH] [6/15] HWPOISON: Add various poison checks in mm/memory.c v2 Andi Kleen
2009-06-04 21:28 ` [PATCH] [7/15] HWPOISON: x86: Add VM_FAULT_HWPOISON handling to x86 page fault handler v2 Andi Kleen
2009-06-04 21:28 ` [PATCH] [8/15] HWPOISON: Use bitmask/action code for try_to_unmap behaviour Andi Kleen
2009-06-04 21:28 ` [PATCH] [9/15] HWPOISON: Handle hardware poisoned pages in try_to_unmap Andi Kleen
2009-06-04 21:28 ` [PATCH] [10/15] HWPOISON: check and isolate corrupted free pages v2 Andi Kleen
2009-06-04 21:28 ` Andi Kleen [this message]
2009-06-09 9:18 ` [PATCH] [11/15] HWPOISON: Refactor truncate to allow direct truncating of page v2 Nick Piggin
2009-06-09 9:31 ` [PATCH] [11/15] HWPOISON: Refactor truncate to allow direct truncating of page v3 Wu Fengguang
2009-06-04 21:28 ` [PATCH] [12/15] HWPOISON: The high level memory error handler in the VM v6 Andi Kleen
2009-06-04 21:28 ` [PATCH] [13/15] HWPOISON: FOR TESTING: Enable memory failure code unconditionally Andi Kleen
2009-06-04 21:28 ` [PATCH] [14/15] HWPOISON: Add madvise() based injector for hardware poisoned pages v3 Andi Kleen
2009-06-04 21:28 ` [PATCH] [15/15] HWPOISON: Add simple debugfs interface to inject hwpoison on arbitary PFNs Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090604212823.16F901D0293@basil.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.orgnpiggin \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox