From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with ESMTP id D55456B0055 for ; Wed, 3 Jun 2009 10:39:07 -0400 (EDT) Date: Tue, 2 Jun 2009 15:46:10 +0200 From: Andi Kleen Subject: Re: [PATCH] [13/16] HWPOISON: The high level memory error handler in the VM v3 Message-ID: <20090602134610.GO1065@one.firstfloor.org> References: <20090528134520.GH1065@one.firstfloor.org> <20090601120537.GF5018@wotan.suse.de> <20090601185147.GT1065@one.firstfloor.org> <20090602121031.GC1392@wotan.suse.de> <20090602123450.GF1065@one.firstfloor.org> <20090602123720.GF1392@wotan.suse.de> <20090602125538.GH1065@one.firstfloor.org> <20090602130306.GA6262@wotan.suse.de> <20090602132002.GJ1065@one.firstfloor.org> <20090602131937.GB6262@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090602131937.GB6262@wotan.suse.de> Sender: owner-linux-mm@kvack.org To: Nick Piggin Cc: Andi Kleen , hugh@veritas.com, riel@redhat.com, akpm@linux-foundation.org, chris.mason@oracle.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, fengguang.wu@intel.com List-ID: On Tue, Jun 02, 2009 at 03:19:37PM +0200, Nick Piggin wrote: > > I assume that if an application does something with EIO it > > can either retry a few times or give up. Both is ok here. > > That's exactly the case where it is not OK, because the > dirty page was now removed from pagecache, so the subsequent > fsync is going to succeed and the app will think its dirty > data has hit disk. Ok that's a fair point -- that's a hole in my scheme. I don't know of a good way to fix it though. Do you? I suspect adding a new errno would break more cases than fixing them. -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org