linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Miller <davem@davemloft.net>,
	riel@redhat.com, research@subreption.com,
	linux-kernel@vger.kernel.org, pageexec@freemail.hu,
	linux-mm@kvack.org, torvalds@osdl.org,
	linux-crypto@vger.kernel.org
Subject: Re: [PATCH] Use kzfree in crypto API context initialization and key/iv handling
Date: Mon, 1 Jun 2009 08:58:14 +0100	[thread overview]
Message-ID: <20090601085814.3e010533@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20090601044837.GA9220@gondor.apana.org.au>

On Mon, 1 Jun 2009 14:48:37 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:

> On Sun, May 31, 2009 at 09:46:23PM -0700, David Miller wrote:
> > 
> > I don't even want to think about what this does to IPSEC rule creation
> > rates, that that matters heavily for cell phone networks where
> > hundreds of thousands of nodes come in and out of the server and each
> > such entry requires creating 4 IPSEC rules.
> 
> I completely agree.  The zeroing of metadata is gratuitous.

Zeroing long term keys makes sense but for the short lifepsan keys used on
the wire its a bit pointless irrespective of speed (I suspect done
properly the performance impact would be close to nil anyway)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-06-01  7:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-31  2:57 Larry H.
2009-05-31  6:02 ` David Miller
2009-05-31 14:38   ` Rik van Riel
2009-06-01  4:46     ` David Miller
2009-06-01  4:48       ` Herbert Xu
2009-06-01  7:58         ` Alan Cox [this message]
2009-06-01 12:33           ` Herbert Xu
2009-05-31 14:38 ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090601085814.3e010533@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=pageexec@freemail.hu \
    --cc=research@subreption.com \
    --cc=riel@redhat.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox