From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
"Larry H." <research@subreption.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH] Use kzfree in tty buffer management to enforce data sanitization
Date: Sun, 31 May 2009 11:26:30 +0100 [thread overview]
Message-ID: <20090531112630.2c7f4f1d@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <84144f020905302324r5e342f2dlfd711241ecfc8374@mail.gmail.com>
> > memset(buf->data, 0, N_TTY_BUF_SIZE);
> > if (PAGE_SIZE != N_TTY_BUF_SIZE)
> > kfree(...)
> > else
> > free_page(...)
> >
> >
> > but quite frankly, I'm not convinced about these patches at all.
>
> I wonder why the tty code has that N_TTY_BUF_SIZE special casing in
> the first place? I think we can probably just get rid of it and thus
> we can use kzfree() here if we want to.
Some platforms with very large page sizes override the use of page based
allocators (eg older ARM would go around allocating 32K). The normal path
is 4K or 8K page sized buffers.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-05-31 10:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-31 1:55 Larry H.
2009-05-31 2:04 ` Linus Torvalds
2009-05-31 2:35 ` Larry H.
2009-05-31 6:27 ` Pekka Enberg
2009-05-31 6:24 ` Pekka Enberg
2009-05-31 10:26 ` Alan Cox [this message]
2009-05-31 17:05 ` Linus Torvalds
2009-05-31 17:10 ` Alan Cox
2009-05-31 17:17 ` Pekka Enberg
2009-06-02 15:05 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090531112630.2c7f4f1d@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
--cc=research@subreption.com \
--cc=riel@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox