From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with ESMTP id 2F7156B00DF for ; Sat, 30 May 2009 13:34:06 -0400 (EDT) Date: Sat, 30 May 2009 19:34:28 +0200 From: Ingo Molnar Subject: Re: [patch 0/5] Support for sanitization flag in low-level page allocator Message-ID: <20090530173428.GA20013@elte.hu> References: <20090523124944.GA23042@elte.hu> <4A187BDE.5070601@redhat.com> <20090527223421.GA9503@elte.hu> <20090528072702.796622b6@lxorguk.ukuu.org.uk> <20090528090836.GB6715@elte.hu> <20090528125042.28c2676f@lxorguk.ukuu.org.uk> <84144f020905300035g1d5461f9n9863d4dcdb6adac0@mail.gmail.com> <20090530075033.GL29711@oblivion.subreption.com> <4A20E601.9070405@cs.helsinki.fi> <20090530082048.GM29711@oblivion.subreption.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090530082048.GM29711@oblivion.subreption.com> Sender: owner-linux-mm@kvack.org To: "Larry H." Cc: Pekka Enberg , Alan Cox , Rik van Riel , linux-kernel@vger.kernel.org, Linus Torvalds , linux-mm@kvack.org, Ingo Molnar , pageexec@freemail.hu, Linus Torvalds List-ID: * Larry H. wrote: > On 10:53 Sat 30 May , Pekka Enberg wrote: > >> That's hopeless, and kzfree is broken. Like I said in my earlier reply, > >> please test that yourself to see the results. Whoever wrote that ignored > >> how SLAB/SLUB work and if kzfree had been used somewhere in the kernel > >> before, it should have been noticed long time ago. > > > > An open-coded version of kzfree was being used in the kernel: > > > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=00fcf2cb6f6bb421851c3ba062c0a36760ea6e53 > > > > Can we now get to the part where you explain how it's broken because I > > obviously "ignored how SLAB/SLUB works"? > > You can find the answer in the code of sanitize_obj, within my > kfree patch. [...] You need to provide a more sufficient and more constructive answer than that, if you propose upstream patches that impact the SLAB subsystem. FYI Pekka is one of the SLAB subsystem maintainers so you need to convince him that your patches are the right approach. Trying to teach Pekka about SLAB internals in a condescending tone will only cause your patches to be ignored. Ingo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org