From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
"hugh.dickins@tiscali.co.uk" <hugh.dickins@tiscali.co.uk>,
"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/4] modify swap_map and add SWAP_HAS_CACHE flag.
Date: Sat, 30 May 2009 19:35:54 +0800 [thread overview]
Message-ID: <20090530113554.GN24073@balbir.in.ibm.com> (raw)
In-Reply-To: <c22c9214cc3a6fcf2224fa556f5558b1.squirrel@webmail-b.css.fujitsu.com>
* KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> [2009-05-30 20:16:51]:
> Balbir Singh wrote:
> >> #define SWAP_CLUSTER_MAX 32
> >>
> >> -#define SWAP_MAP_MAX 0x7fff
> >> -#define SWAP_MAP_BAD 0x8000
> >> -
> >> +#define SWAP_MAP_MAX 0x7ffe
> >> +#define SWAP_MAP_BAD 0x7fff
> >> +#define SWAP_HAS_CACHE 0x8000 /* There is a swap cache of entry. */
> >
> > Why count, can't we use swp->flags?
> >
>
> Hmm ? swap_map just only a "unsiged short" value per entry..sorry,
> I can't catch what you mention to.
Sorry for the noise, the count is directly contained in swap_map[].
--
Balbir
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-05-30 11:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-28 4:54 [PATCH 0/4] memcg fix swap accounting (28/May) KAMEZAWA Hiroyuki
2009-05-28 5:10 ` [PATCH 1/4] add swap cache interface for swap reference KAMEZAWA Hiroyuki
2009-05-29 4:21 ` Daisuke Nishimura
2009-05-29 5:08 ` KAMEZAWA Hiroyuki
2009-05-29 5:37 ` [PATCH 1/4] add swap cache interface for swap reference v2 (updated) KAMEZAWA Hiroyuki
2009-05-29 6:05 ` Daisuke Nishimura
2009-05-29 6:53 ` KAMEZAWA Hiroyuki
2009-05-30 5:21 ` Balbir Singh
2009-05-28 5:19 ` [PATCH 2/4] modify swap_map and add SWAP_HAS_CACHE flag KAMEZAWA Hiroyuki
2009-05-30 6:10 ` Balbir Singh
2009-05-30 11:16 ` KAMEZAWA Hiroyuki
2009-05-30 11:35 ` Balbir Singh [this message]
2009-06-01 7:04 ` Daisuke Nishimura
2009-05-28 5:20 ` [PATCH 3/4] reuse unused swap entry if necessary KAMEZAWA Hiroyuki
2009-05-29 21:55 ` Andrew Morton
2009-05-30 11:11 ` KAMEZAWA Hiroyuki
2009-05-30 6:40 ` Balbir Singh
2009-05-28 5:21 ` [PATCH 4/4] memcg: fix swap accounting KAMEZAWA Hiroyuki
2009-05-30 7:20 ` Balbir Singh
2009-06-02 3:04 [PATCH 0/4] memcg fix swap accounting (2/Jun) KAMEZAWA Hiroyuki
2009-06-02 3:09 ` [PATCH 2/4] modify swap map and add swap has cache flag KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090530113554.GN24073@balbir.in.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hugh.dickins@tiscali.co.uk \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox