From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: "linux-mm@kvack.org" <linux-mm@kvack.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
"hugh.dickins@tiscali.co.uk" <hugh.dickins@tiscali.co.uk>,
"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: [PATCH 0/4] memcg fix swap accounting (28/May)
Date: Thu, 28 May 2009 13:54:55 +0900 [thread overview]
Message-ID: <20090528135455.0c83bedc.kamezawa.hiroyu@jp.fujitsu.com> (raw)
Removed "RFC"
This patch series is restructured as following. some bugs are fixed.
Thank you for all your helps.
[1/4] ....change interface of swap_duplicate()/swap_free()
Adds an function swapcache_prepare() and swapcache_free().
[2/4] ....add SWAP_HAS_CACHE flag and modify reference counting in swap_map
Add SWAP_HAS_CACHE flag to swap_map array for knowing an information that
"there is an only swap cache and swap has no reference"
without extra call of find_get_page().
[3/4] ....reclaim swap-cache-only swap_entry when get_swap_page() find it.
Now, swap_map can tell "there is no reference other than cache", we
can reclaim it if necessary.
This code reclaim swap entries if
- vm_swap_full()==ture
&& there is no free swap cluster
&& get_swap_page() finds unused swap entry.
[4/4].... fix memcg's swap accounting
This is for fixing memcg's swap account leak. like this
==
processA | processB
-------------------------------------+-------------------------------------
(free_swap_and_cache()) | (read_swap_cache_async())
| swap_duplicate()
| __set_page_locked()
| add_to_swap_cache()
swap_entry_free() == 0 |
find_get_page() -> found |
try_lock_page() -> fail & return |
| lru_cache_add_anon()
| doesn't link this page to memcg's
| LRU, because of !PageCgroupUsed.
==
This patch tries to fix this by uncharging account when swap's refcnt goes
to 0 even if there is an unused swap-cache.
Works quite well in my test.
Thanks,
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2009-05-28 4:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-28 4:54 KAMEZAWA Hiroyuki [this message]
2009-05-28 5:10 ` [PATCH 1/4] add swap cache interface for swap reference KAMEZAWA Hiroyuki
2009-05-29 4:21 ` Daisuke Nishimura
2009-05-29 5:08 ` KAMEZAWA Hiroyuki
2009-05-29 5:37 ` [PATCH 1/4] add swap cache interface for swap reference v2 (updated) KAMEZAWA Hiroyuki
2009-05-29 6:05 ` Daisuke Nishimura
2009-05-29 6:53 ` KAMEZAWA Hiroyuki
2009-05-30 5:21 ` Balbir Singh
2009-05-28 5:19 ` [PATCH 2/4] modify swap_map and add SWAP_HAS_CACHE flag KAMEZAWA Hiroyuki
2009-05-30 6:10 ` Balbir Singh
2009-05-30 11:16 ` KAMEZAWA Hiroyuki
2009-05-30 11:35 ` Balbir Singh
2009-06-01 7:04 ` Daisuke Nishimura
2009-05-28 5:20 ` [PATCH 3/4] reuse unused swap entry if necessary KAMEZAWA Hiroyuki
2009-05-29 21:55 ` Andrew Morton
2009-05-30 11:11 ` KAMEZAWA Hiroyuki
2009-05-30 6:40 ` Balbir Singh
2009-05-28 5:21 ` [PATCH 4/4] memcg: fix swap accounting KAMEZAWA Hiroyuki
2009-05-30 7:20 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090528135455.0c83bedc.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=hugh.dickins@tiscali.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox