Re: [RFC][PATCH 2/5] add SWAP_HAS_CACHE flag to swap_map

[KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>]

On Thu, 28 May 2009 10:40:13 +0900
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:

> > > So I think it should be like:
> > > 
> > > 	read_swap_cache_async()
> > > 		:
> > > 		valid = swapcache_prepare(entry);
> > > 		if (!valid)
> > > 			break;
> > > 		if (valid == -EAGAIN);
> > > 			continue;
> > > 
> > > to let the context that succeeded in swapcache_prepare() do add_to_swap_cache().
> > > 
> > 
> > What you reccomend is code like this ?
> > 
> > ==
> > 	ret = swapcache_prapare(entry);
> > 	if (ret == -ENOENT)
> > 		break;    /* unused swap entry */
> > 	if (ret == -EBUSY)
> > 		continue; /* to call find_get_page() again */
> > ==
> > 
> Yes.
> By current version of your patch, read_swap_cache_async() might return NULL
> if concurrent read_swap_cache_async() exists. It is different from current behavior.
> And this means swapin_readahead() might fail(it calls read_swap_cache_async()
> twice, though) and can cause oom, right ?
> 
Good point. I fixed this in a patch in my box ;)
Thank you fot good review.

Thanks,
-Kame



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>