From: Andrew Morton <akpm@linux-foundation.org>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>, Mel Gorman <mel@csn.ul.ie>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Rik van Riel <riel@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Yasunori Goto <y-goto@jp.fujitsu.com>
Subject: Re: [PATCH 2/3] add inactive ratio calculation function of each zone V2
Date: Tue, 26 May 2009 22:30:02 -0700 [thread overview]
Message-ID: <20090526223002.f283bcd2.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090521092321.ee57585e.minchan.kim@barrios-desktop>
On Thu, 21 May 2009 09:23:21 +0900 Minchan Kim <minchan.kim@gmail.com> wrote:
> Changelog since V1
> o Change function name from calculate_zone_inactive_ratio to calculate_inactive_ratio
> - by Mel Gorman advise
> o Modify tab indent - by Mel Gorman advise
The first two patches still had various trivial whitespace bustages.
You don't need Mel to find these things when we have the very nice
scripts/checkpatch.pl. Please incorporate that script into your patch
preparation tools
> This patch devide setup_per_zone_inactive_ratio with
> per-zone inactive ratio calculaton.
The above sentence appears to be the changelog for this patch but it
doesn't make a lot of sense.
afaict the changelog should be:
"factor the per-zone arithemetic inside
setup_per_zone_inactive_ratio()'s loop into a a separate function,
calculate_zone_inactive_ratio(). This function will be used in a later
patch".
yes?
> This patch is just for helping my next patch.
> (reset wmark_min and inactive ratio of zone when hotplug happens)
>
> Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
> Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> CC: Rik van Riel <riel@redhat.com>
> CC: Johannes Weiner <hannes@cmpxchg.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-05-27 5:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 0:23 Minchan Kim
2009-05-25 9:00 ` Mel Gorman
2009-05-27 5:30 ` Andrew Morton [this message]
2009-05-27 6:05 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090526223002.f283bcd2.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox