From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with ESMTP id 1058A6B005D for ; Tue, 26 May 2009 16:41:44 -0400 (EDT) Date: Tue, 26 May 2009 13:41:34 -0700 From: Andrew Morton Subject: Re: [PATCH][mmtom] clean up once printk routine Message-Id: <20090526134134.bb3e1e23.akpm@linux-foundation.org> In-Reply-To: <20090526155943.aef3ba62.minchan.kim@barrios-desktop> References: <20090526135733.3c38f758.minchan.kim@barrios-desktop> <20090526155155.6871.A69D9226@jp.fujitsu.com> <20090526155943.aef3ba62.minchan.kim@barrios-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Minchan Kim Cc: kosaki.motohiro@jp.fujitsu.com, randy.dunlap@oracle.com, cl@linux-foundation.org, linux-mm@kvack.org, pavel@ucw.cz, dave@linux.vnet.ibm.com, davem@davemloft.net, linux@dominikbrodowski.net, mingo@elte.hu, linux-kernel@vger.kernel.org List-ID: On Tue, 26 May 2009 15:59:43 +0900 Minchan Kim wrote: > On Tue, 26 May 2009 15:52:32 +0900 (JST) > KOSAKI Motohiro wrote: > > > > == CUT HERE == > > > > > > There are some places to be able to use printk_once instead of hard coding. > > > > > > It will help code readability and maintenance. > > > This patch doesn't change function's behavior. > > > > > > Signed-off-by: Minchan Kim > > > CC: Dominik Brodowski > > > CC: David S. Miller > > > CC: Ingo Molnar > > > --- > > > arch/x86/kernel/cpu/common.c | 8 ++------ > > > drivers/net/3c515.c | 7 ++----- > > > drivers/pcmcia/pcmcia_ioctl.c | 9 +++------ > > > 3 files changed, 7 insertions(+), 17 deletions(-) > > > > Please separete to three patches ;) > > After I listen about things I missed, I will repost it at all once with each patch. Yes, that would be better. But for a trivial little patch like this I expect we can just merge it and move on. But please do split up these multi-subsystem patches in future. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org