From: Rusty Russell <rusty@rustcorp.com.au>
To: Tejun Heo <tj@kernel.org>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org, x86@kernel.org,
ink@jurassic.park.msu.ru, rth@twiddle.net,
linux@arm.linux.org.uk, hskinnemoen@atmel.com,
cooloney@kernel.org, starvik@axis.com, jesper.nilsson@axis.com,
dhowells@redhat.com, ysato@users.sourceforge.jp,
tony.luck@intel.com, takata@linux-m32r.org, geert@linux-m68k.org,
monstr@monstr.eu, ralf@linux-mips.org, kyle@mcmartin.ca,
benh@kernel.crashing.org, paulus@samba.org,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
lethal@linux-sh.org, davem@davemloft.net, jdike@addtoit.com,
chris@zankel.net, Jens Axboe <jens.axboe@oracle.com>,
Dave Jones <davej@redhat.com>,
Jeremy Fitzhardinge <jeremy@xensource.com>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH 3/7] percpu: clean up percpu variable definitions
Date: Mon, 25 May 2009 15:37:34 +0930 [thread overview]
Message-ID: <200905251537.35981.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1242805059-18338-4-git-send-email-tj@kernel.org>
On Wed, 20 May 2009 05:07:35 pm Tejun Heo wrote:
> Percpu variable definition is about to be updated such that
>
> * percpu symbols must be unique even the static ones
>
> * in-function static definition is not allowed
That spluttering noise is be choking on the title of this patch :)
Making these pseudo statics is in no way a cleanup. How about we just
say "they can't be static" and do something like:
/* Sorry, can't be static: that breaks archs which need these weak. */
#define DEFINE_PER_CPU(type, var) \
extern typeof(type) var; DEFINE_PER_CPU_SECTION(type, name, "")
Thanks,
Rusty.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-05-25 10:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1242805059-18338-1-git-send-email-tj@kernel.org>
2009-05-20 7:37 ` Tejun Heo
2009-05-20 9:17 ` Jens Axboe
2009-05-25 6:07 ` Rusty Russell [this message]
2009-05-25 16:07 ` Tejun Heo
[not found] <1243846708-805-1-git-send-email-tj@kernel.org>
2009-06-01 8:58 ` Tejun Heo
2009-06-01 9:40 ` David Miller
2009-06-01 11:36 ` Tejun Heo
2009-06-02 5:08 ` Benjamin Herrenschmidt
2009-06-05 4:25 ` Tejun Heo
2009-06-11 10:45 ` Jesper Nilsson
2009-06-17 2:28 ` Tejun Heo
2009-06-10 18:30 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905251537.35981.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=benh@kernel.crashing.org \
--cc=chris@zankel.net \
--cc=cooloney@kernel.org \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=geert@linux-m68k.org \
--cc=heiko.carstens@de.ibm.com \
--cc=hskinnemoen@atmel.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jdike@addtoit.com \
--cc=jens.axboe@oracle.com \
--cc=jeremy@xensource.com \
--cc=jesper.nilsson@axis.com \
--cc=kyle@mcmartin.ca \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@elte.hu \
--cc=monstr@monstr.eu \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=rth@twiddle.net \
--cc=schwidefsky@de.ibm.com \
--cc=starvik@axis.com \
--cc=takata@linux-m32r.org \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox