From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>
Subject: Re: [RFC][PATCH] synchrouns swap freeing at zapping vmas
Date: Fri, 22 May 2009 14:05:55 +0900 [thread overview]
Message-ID: <20090522140555.384470ea.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20090522133906.66fea0fe.nishimura@mxp.nes.nec.co.jp>
On Fri, 22 May 2009 13:39:06 +0900
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:
> On Thu, 21 May 2009 16:41:00 +0900, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> - Using shmem caused a BUG.
>
> BUG: sleeping function called from invalid context at include/linux/pagemap.h:327
> in_atomic(): 1, irqs_disabled(): 0, pid: 1113, name: shmem_test_02
> no locks held by shmem_test_02/1113.
> Pid: 1113, comm: shmem_test_02 Not tainted 2.6.30-rc5-69e923d8 #2
> Call Trace:
> [<ffffffff802ad004>] ? free_swap_batch+0x40/0x7f
> [<ffffffff80299b58>] ? shmem_free_swp+0xac/0xca
> [<ffffffff8029a0f1>] ? shmem_truncate_range+0x57b/0x7af
> [<ffffffff80378393>] ? __percpu_counter_add+0x3e/0x5c
> [<ffffffff8029c458>] ? shmem_delete_inode+0x77/0xd3
> [<ffffffff8029c3e1>] ? shmem_delete_inode+0x0/0xd3
> [<ffffffff802d3ab7>] ? generic_delete_inode+0xe0/0x178
> [<ffffffff802d0dda>] ? d_kill+0x24/0x46
> [<ffffffff802d2212>] ? dput+0x134/0x141
> [<ffffffff802c3504>] ? __fput+0x189/0x1ba
> [<ffffffff802a50e4>] ? remove_vma+0x4e/0x83
> [<ffffffff802a5224>] ? exit_mmap+0x10b/0x129
> [<ffffffff80238fbd>] ? mmput+0x41/0x9f
> [<ffffffff8023cf37>] ? exit_mm+0x101/0x10c
> [<ffffffff8023e439>] ? do_exit+0x1a0/0x61a
> [<ffffffff80259253>] ? trace_hardirqs_on_caller+0x113/0x13e
> [<ffffffff8023e926>] ? do_group_exit+0x73/0xa5
> [<ffffffff8023e96a>] ? sys_exit_group+0x12/0x16
> [<ffffffff8020b96b>] ? system_call_fastpath+0x16/0x1b
>
> (include/linux/pagemap.h)
> 325 static inline void lock_page(struct page *page)
> 326 {
> 327 might_sleep();
> 328 if (!trylock_page(page))
> 329 __lock_page(page);
> 330 }
> 331
>
>
> I hope they would be some help for you.
>
Thanks, I have to drop this patch ;)
Now, I found a very clean new way....I think (modify memcg's logic).
Thank you for your contribution and patience.
Thanks,
-Kame
> Thanks,
> Daisuke Nishimura.
>
> > Any comments are welcome.
> >
> > Thanks,
> > -Kame
> >
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2009-05-22 5:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 7:41 KAMEZAWA Hiroyuki
2009-05-21 7:43 ` [RFC][PATCH 1/2] change swapcount handling KAMEZAWA Hiroyuki
2009-05-21 7:43 ` [RFC][PATCH 2/2] synchrouns swap freeing without trylock KAMEZAWA Hiroyuki
2009-05-21 12:44 ` Johannes Weiner
2009-05-21 23:46 ` KAMEZAWA Hiroyuki
2009-05-21 21:00 ` [RFC][PATCH] synchrouns swap freeing at zapping vmas Hugh Dickins
2009-05-22 0:26 ` KAMEZAWA Hiroyuki
2009-05-22 4:39 ` Daisuke Nishimura
2009-05-22 5:05 ` KAMEZAWA Hiroyuki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090522140555.384470ea.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=hugh.dickins@tiscali.co.uk \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox