From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with SMTP id 250145F0001 for ; Tue, 14 Apr 2009 00:36:40 -0400 (EDT) Received: from m6.gw.fujitsu.co.jp ([10.0.50.76]) by fgwmail6.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id n3E4bCE5018331 for (envelope-from kosaki.motohiro@jp.fujitsu.com); Tue, 14 Apr 2009 13:37:12 +0900 Received: from smail (m6 [127.0.0.1]) by outgoing.m6.gw.fujitsu.co.jp (Postfix) with ESMTP id DC72245DE56 for ; Tue, 14 Apr 2009 13:37:11 +0900 (JST) Received: from s6.gw.fujitsu.co.jp (s6.gw.fujitsu.co.jp [10.0.50.96]) by m6.gw.fujitsu.co.jp (Postfix) with ESMTP id B035945DE50 for ; Tue, 14 Apr 2009 13:37:11 +0900 (JST) Received: from s6.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s6.gw.fujitsu.co.jp (Postfix) with ESMTP id A46451DB8041 for ; Tue, 14 Apr 2009 13:37:11 +0900 (JST) Received: from m106.s.css.fujitsu.com (m106.s.css.fujitsu.com [10.249.87.106]) by s6.gw.fujitsu.co.jp (Postfix) with ESMTP id 24DD51DB8044 for ; Tue, 14 Apr 2009 13:37:11 +0900 (JST) From: KOSAKI Motohiro Subject: Re: [RFC][PATCH] proc: export more page flags in /proc/kpageflags In-Reply-To: <20090414042231.GA4341@localhost> References: <20090414042231.GA4341@localhost> Message-Id: <20090414133448.C645.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Date: Tue, 14 Apr 2009 13:37:10 +0900 (JST) Sender: owner-linux-mm@kvack.org To: Wu Fengguang Cc: kosaki.motohiro@jp.fujitsu.com, Andrew Morton , Andi Kleen , LKML , linux-mm@kvack.org List-ID: > Export the following page flags in /proc/kpageflags, > just in case they will be useful to someone: > > - PG_swapcache > - PG_swapbacked > - PG_mappedtodisk > - PG_reserved > - PG_private > - PG_private_2 > - PG_owner_priv_1 > > - PG_head > - PG_tail > - PG_compound > > - PG_unevictable > - PG_mlocked > > - PG_poison Sorry, NAK this. We shouldn't expose internal flags. please choice useful flags only. > > Also add the following two pseudo page flags: > > - PG_MMAP: whether the page is memory mapped > - PG_NOPAGE: whether the page is present > > This increases the total number of exported page flags to 25. > > Cc: Andi Kleen > Cc: Matt Mackall > Cc: Alexey Dobriyan > Signed-off-by: Wu Fengguang > --- > fs/proc/page.c | 112 +++++++++++++++++++++++++++++++++-------------- > 1 file changed, 81 insertions(+), 31 deletions(-) > > --- mm.orig/fs/proc/page.c > +++ mm/fs/proc/page.c > @@ -68,20 +68,86 @@ static const struct file_operations proc > > /* These macros are used to decouple internal flags from exported ones */ > > -#define KPF_LOCKED 0 > -#define KPF_ERROR 1 > -#define KPF_REFERENCED 2 > -#define KPF_UPTODATE 3 > -#define KPF_DIRTY 4 > -#define KPF_LRU 5 > -#define KPF_ACTIVE 6 > -#define KPF_SLAB 7 > -#define KPF_WRITEBACK 8 > -#define KPF_RECLAIM 9 > -#define KPF_BUDDY 10 > +enum { > + KPF_LOCKED, /* 0 */ > + KPF_ERROR, /* 1 */ > + KPF_REFERENCED, /* 2 */ > + KPF_UPTODATE, /* 3 */ > + KPF_DIRTY, /* 4 */ > + KPF_LRU, /* 5 */ > + KPF_ACTIVE, /* 6 */ > + KPF_SLAB, /* 7 */ > + KPF_WRITEBACK, /* 8 */ > + KPF_RECLAIM, /* 9 */ > + KPF_BUDDY, /* 10 */ > + KPF_MMAP, /* 11 */ > + KPF_SWAPCACHE, /* 12 */ > + KPF_SWAPBACKED, /* 13 */ > + KPF_MAPPEDTODISK, /* 14 */ > + KPF_RESERVED, /* 15 */ > + KPF_PRIVATE, /* 16 */ > + KPF_PRIVATE2, /* 17 */ > + KPF_OWNER_PRIVATE, /* 18 */ > + KPF_COMPOUND_HEAD, /* 19 */ > + KPF_COMPOUND_TAIL, /* 20 */ > + KPF_UNEVICTABLE, /* 21 */ > + KPF_MLOCKED, /* 22 */ > + KPF_POISON, /* 23 */ > + KPF_NOPAGE, /* 24 */ > + KPF_NUM > +}; this is userland export value. then enum is wrong idea. explicit name-number relationship is better. it prevent unintetional ABI break. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org