From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with SMTP id 4B57B5F0001 for ; Mon, 6 Apr 2009 20:06:07 -0400 (EDT) Received: from m2.gw.fujitsu.co.jp ([10.0.50.72]) by fgwmail5.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id n3706AUo025653 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Tue, 7 Apr 2009 09:06:10 +0900 Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 1F3AC45DE63 for ; Tue, 7 Apr 2009 09:06:07 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id E4ABA45DE61 for ; Tue, 7 Apr 2009 09:06:05 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id B1469E38008 for ; Tue, 7 Apr 2009 09:06:05 +0900 (JST) Received: from m108.s.css.fujitsu.com (m108.s.css.fujitsu.com [10.249.87.108]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id A42D21DB8041 for ; Tue, 7 Apr 2009 09:06:04 +0900 (JST) Date: Tue, 7 Apr 2009 09:04:38 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [RFC][PATCH 3/9] soft limit update filter Message-Id: <20090407090438.9646e90c.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20090406094351.GI7082@balbir.in.ibm.com> References: <20090403170835.a2d6cbc3.kamezawa.hiroyu@jp.fujitsu.com> <20090403171202.cd7e094b.kamezawa.hiroyu@jp.fujitsu.com> <20090406094351.GI7082@balbir.in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: balbir@linux.vnet.ibm.com Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "kosaki.motohiro@jp.fujitsu.com" List-ID: On Mon, 6 Apr 2009 15:13:51 +0530 Balbir Singh wrote: > * KAMEZAWA Hiroyuki [2009-04-03 17:12:02]: > > > No changes from v1. > > == > > From: KAMEZAWA Hiroyuki > > > > Check/Update softlimit information at every charge is over-killing, so > > we need some filter. > > > > This patch tries to count events in the memcg and if events > threshold > > tries to update memcg's soft limit status and reset event counter to 0. > > > > Event counter is maintained by per-cpu which has been already used, > > Then, no siginificant overhead(extra cache-miss etc..) in theory. > > > > Signed-off-by: KAMEZAWA Hiroyuki > > --- > > Index: mmotm-2.6.29-Mar23/mm/memcontrol.c > > =================================================================== > > --- mmotm-2.6.29-Mar23.orig/mm/memcontrol.c > > +++ mmotm-2.6.29-Mar23/mm/memcontrol.c > > @@ -66,6 +66,7 @@ enum mem_cgroup_stat_index { > > MEM_CGROUP_STAT_PGPGIN_COUNT, /* # of pages paged in */ > > MEM_CGROUP_STAT_PGPGOUT_COUNT, /* # of pages paged out */ > > > > + MEM_CGROUP_STAT_EVENTS, /* sum of page-in/page-out for internal use */ > > MEM_CGROUP_STAT_NSTATS, > > }; > > > > @@ -105,6 +106,22 @@ static s64 mem_cgroup_local_usage(struct > > return ret; > > } > > > > +/* For intenal use of per-cpu event counting. */ > > + > > +static inline void > > +__mem_cgroup_stat_reset_safe(struct mem_cgroup_stat_cpu *stat, > > + enum mem_cgroup_stat_index idx) > > +{ > > + stat->count[idx] = 0; > > +} > > Why do we do this and why do we need a special event? > 2 points. 1. we do "reset" this counter. 2. We're counting page-in/page-out. I wonder I should counter others... > > + > > +static inline s64 > > +__mem_cgroup_stat_read_local(struct mem_cgroup_stat_cpu *stat, > > + enum mem_cgroup_stat_index idx) > > +{ > > + return stat->count[idx]; > > +} > > + > > /* > > * per-zone information in memory controller. > > */ > > @@ -235,6 +252,8 @@ static void mem_cgroup_charge_statistics > > else > > __mem_cgroup_stat_add_safe(cpustat, > > MEM_CGROUP_STAT_PGPGOUT_COUNT, 1); > > + __mem_cgroup_stat_add_safe(cpustat, MEM_CGROUP_STAT_EVENTS, 1); > > + > > put_cpu(); > > } > > > > @@ -897,9 +916,26 @@ static void record_last_oom(struct mem_c > > mem_cgroup_walk_tree(mem, NULL, record_last_oom_cb); > > } > > > > +#define SOFTLIMIT_EVENTS_THRESH (1024) /* 1024 times of page-in/out */ > > +/* > > + * Returns true if sum of page-in/page-out events since last check is > > + * over SOFTLIMIT_EVENT_THRESH. (counter is per-cpu.) > > + */ > > static bool mem_cgroup_soft_limit_check(struct mem_cgroup *mem) > > { > > - return false; > > + bool ret = false; > > + int cpu = get_cpu(); > > + s64 val; > > + struct mem_cgroup_stat_cpu *cpustat; > > + > > + cpustat = &mem->stat.cpustat[cpu]; > > + val = __mem_cgroup_stat_read_local(cpustat, MEM_CGROUP_STAT_EVENTS); > > + if (unlikely(val > SOFTLIMIT_EVENTS_THRESH)) { > > + __mem_cgroup_stat_reset_safe(cpustat, MEM_CGROUP_STAT_EVENTS); > > + ret = true; > > + } > > + put_cpu(); > > + return ret; > > } > > > > It is good to have the caller and the function in the same patch. > Otherwise, you'll notice unused warnings. I think this function can be > simplified further > > 1. Lets gid rid of MEM_CGRUP_STAT_EVENTS > 2. Lets rewrite mem_cgroup_soft_limit_check as > > static bool mem_cgroup_soft_limit_check(struct mem_cgroup *mem) > { > bool ret = false; > int cpu = get_cpu(); > s64 pgin, pgout; > struct mem_cgroup_stat_cpu *cpustat; > > cpustat = &mem->stat.cpustat[cpu]; > pgin = __mem_cgroup_stat_read_local(cpustat, MEM_CGROUP_STAT_PGPGIN_COUNT); > pgout = __mem_cgroup_stat_read_local(cpustat, MEM_CGROUP_STAT_PGPGOUT_COUNT); > val = pgin + pgout - mem->last_event_count; > if (unlikely(val > SOFTLIMIT_EVENTS_THRESH)) { > mem->last_event_count = pgin + pgout; > ret = true; > } > put_cpu(); > return ret; > } > > mem->last_event_count can either be atomic or protected using one of > the locks you intend to introduce. This will avoid the overhead of > incrementing event at every charge_statistics. > Incrementing always hits cache. Hmm, making mem->last_event_count as per-cpu, we can do above. And maybe no difference with current code. But you don't seem to like counting, it's ok to change the shape. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org