Re: [RFC][PATCH 7/8] memcg soft limit LRU reorder

[Balbir Singh <balbir@linux.vnet.ibm.com>]

* KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> [2009-03-31 09:00:23]:

> On Mon, 30 Mar 2009 13:22:46 +0530
> Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> 
> > * KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> [2009-03-27 14:12:25]:
> > 
> > > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> > > 
> > > This patch adds a function to change the LRU order of pages in global LRU
> > > under control of memcg's victim of soft limit.
> > > 
> > > FILE and ANON victim is divided and LRU rotation will be done independently.
> > > (memcg which only includes FILE cache or ANON can exists.)
> > > 
> > > The routine finds specfied number of pages from memcg's LRU and
> > > move it to top of global LRU. They will be the first target of shrink_xxx_list.
> > 
> > This seems to be the core of the patch, but I don't like this very
> > much. Moving LRU pages of the mem cgroup seems very subtle, why can't
> > we directly use try_to_free_mem_cgroup_pages()?
> > 
> It ignores many things.

My concern is that such subtle modification to the global LRU 

1. Can break the age property of elements in the LRU (we have mixed
ages now in the LRU)
2. Can potentially impact lumpy reclaim, since we've mix LRU pages
from the memory controlelr into the global LRU?

-- 
	Balbir

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>