Re: [RFC][BUGFIX][PATCH] memcg: fix shrink_usage

[KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>]

On Thu, 26 Mar 2009 15:38:03 +0900
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:


> > Seems very simple. hmm, I'm thinking of following.
> > ==
> > int mem_cgroup_shmem_charge_fallback(struct page *page, struct mm_struct *mm, gfp_t mask)
> > {
> > 	return mem_cgroup_cache_charge(mm, page, mask);
> > }
> > ==
> > 
> > But I'm afraid that this adds another corner case to account the page not under
> > radix-tree. (But this is SwapCache...then...this will work.)
> > 
> > Could you write a patch in this direction ? (or I'll write by myself.)
> > It's obvious that you do better test.
> > 
> Okey.
> 
> I'll make a patch and repost it after doing some tests for review.
> 
> BTW, do you have any good idea about the new name of shrink_usage ?
> 
See above ;) mem_cgroup_shmem_charge_fallback() seems to be straightforward.
I'm glad if you rewrite the comment to function at the same time :)

Thanks,
-Kame

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>