From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with SMTP id C5D936B005C for ; Sun, 22 Mar 2009 21:27:45 -0400 (EDT) Received: from m6.gw.fujitsu.co.jp ([10.0.50.76]) by fgwmail6.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id n2N2N1dA010199 for (envelope-from kosaki.motohiro@jp.fujitsu.com); Mon, 23 Mar 2009 11:23:02 +0900 Received: from smail (m6 [127.0.0.1]) by outgoing.m6.gw.fujitsu.co.jp (Postfix) with ESMTP id 5F74645DD72 for ; Mon, 23 Mar 2009 11:23:01 +0900 (JST) Received: from s6.gw.fujitsu.co.jp (s6.gw.fujitsu.co.jp [10.0.50.96]) by m6.gw.fujitsu.co.jp (Postfix) with ESMTP id 38AE345DE56 for ; Mon, 23 Mar 2009 11:23:01 +0900 (JST) Received: from s6.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s6.gw.fujitsu.co.jp (Postfix) with ESMTP id 270AA1DB8045 for ; Mon, 23 Mar 2009 11:23:01 +0900 (JST) Received: from ml13.s.css.fujitsu.com (ml13.s.css.fujitsu.com [10.249.87.103]) by s6.gw.fujitsu.co.jp (Postfix) with ESMTP id D37E21DB8042 for ; Mon, 23 Mar 2009 11:23:00 +0900 (JST) From: KOSAKI Motohiro Subject: Re: [patch 2/3] ramfs-nommu: use generic lru cache In-Reply-To: <1237752784-1989-2-git-send-email-hannes@cmpxchg.org> References: <20090321102044.GA3427@cmpxchg.org> <1237752784-1989-2-git-send-email-hannes@cmpxchg.org> Message-Id: <20090323112219.69F6.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Date: Mon, 23 Mar 2009 11:22:59 +0900 (JST) Sender: owner-linux-mm@kvack.org To: Johannes Weiner Cc: kosaki.motohiro@jp.fujitsu.com, Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Howells , Nick Piggin , Rik van Riel , Peter Zijlstra , MinChan Kim , Lee Schermerhorn List-ID: > Instead of open-coding the lru-list-add pagevec batching when > expanding a file mapping from zero, defer to the appropriate page > cache function that also takes care of adding the page to the lru > list. > > This is cleaner, saves code and reduces the stack footprint by 16 > words worth of pagevec. Looks good to me. thanks good patch. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org