From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: kosaki.motohiro@jp.fujitsu.com,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
mel@csn.ul.ie, riel@redhat.com,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [PATCH] fix vmscan to take care of nodemask
Date: Mon, 23 Mar 2009 10:20:18 +0900 (JST) [thread overview]
Message-ID: <20090323101632.69E7.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <20090323101348.07b9c761.kamezawa.hiroyu@jp.fujitsu.com>
> Kosaki pointed out it's not necessary to initialize struct member value by NULL.
> Remvoed it.
>
> Regards,
> -Kame
> ==
> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
> try_to_free_pages() scans zonelist but don't take care of nodemask which is
> given to alloc_pages_nodemask(). This makes try_to_free_pages() less effective.
Yes, ignore nodemask make unnecessary reclaim. it decrease try_to_free_pages()
performance.
Note: currently, try_to_free_pages() stop to process reclaim after 32 pages reclaimed.
then, non intentional node scanning can cause large performance degression.
>
> Changelog: v1 -> v2
> - removed unnecessary nodemask=NULL initialization.
>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
thanks.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-03-23 0:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-23 1:03 KAMEZAWA Hiroyuki
2009-03-23 1:13 ` KAMEZAWA Hiroyuki
2009-03-23 1:20 ` KOSAKI Motohiro [this message]
2009-03-23 11:48 ` Mel Gorman
2009-03-23 13:38 ` Christoph Lameter
2009-03-23 15:31 ` KOSAKI Motohiro
2009-03-23 15:39 ` Christoph Lameter
2009-03-24 1:31 ` KAMEZAWA Hiroyuki
2009-03-24 2:26 ` [PATCH] fix vmscan to take care of nodemask v3 KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090323101632.69E7.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox