From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with ESMTP id 5D8946B003D for ; Thu, 19 Mar 2009 19:04:52 -0400 (EDT) Date: Thu, 19 Mar 2009 23:04:45 +0000 From: Mel Gorman Subject: Re: [PATCH 20/35] Use a pre-calculated value for num_online_nodes() Message-ID: <20090319230445.GG24586@csn.ul.ie> References: <20090316163626.GJ24293@csn.ul.ie> <20090318150833.GC4629@csn.ul.ie> <20090318180152.GB24462@csn.ul.ie> <20090319222106.GD24586@csn.ul.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org To: Christoph Lameter Cc: Linux Memory Management List , Pekka Enberg , Rik van Riel , KOSAKI Motohiro , Johannes Weiner , Nick Piggin , Linux Kernel Mailing List , Lin Ming , Zhang Yanmin , Peter Zijlstra List-ID: On Thu, Mar 19, 2009 at 06:24:02PM -0400, Christoph Lameter wrote: > On Thu, 19 Mar 2009, Mel Gorman wrote: > > > On Thu, Mar 19, 2009 at 04:43:55PM -0400, Christoph Lameter wrote: > > > Trying to the same in the style of nr_node_ids etc. > > > > > > > Because of some issues with the patch and what it does for possible > > nodes, I reworked the patch slightly into the following and is what I'm > > actually testing. > > Ok. It also removes the slab bits etc. > Well ... yes. One of the slab changes removed a variable called numa_platform. From your patch, this appears to have some relation to nr_possible_nodes but it's not obvious at all if that is true or not. The second change replaced num_possible_nodes() with nr_possible_nodes() but it wasn't clear this was equivalent because nr_possible_nodes() doesn't get updated from the call sites affecting the "possible" bitmap. Both of those changes belong in a different patch and need explaination. The bits left alter just nr_online_nodes and use it where it's important. -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org