Re: [RFC] memcg: handle swapcache leak

[KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>]

On Wed, 18 Mar 2009 12:51:54 +0900
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:

> > I'm sorry if I miss your point.
> > 
> > 
> Yes, there would be no problem of swp_entry leak, but these pages, which have
> been removed from swapcache and are being free'ed by free_swap_and_cache,
> cannot be removed from orphan_lru, although they are removed from global LRU, right ?
> 
Ah, I see. thank you. SwapCache flags is deleted before deleting from LRU.
OK, will fix.

> > 
> It may work for type-1 of swapcaches that I described in first mail,
> because memsw charges of them are not uncharged while they are on swapcache.
> 
> But it doesn't work for type-2 of swapcaches because they are uncharged
> from both mem and memsw.
> 
> Hmm, should I send a patch for shrink_page_list() attached in first mail
> as another patch ?
> 
Ok, just check the number of pages on orphan list.

Thanks,
-Kame

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>