From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with ESMTP id 128BD6B0047 for ; Mon, 16 Mar 2009 12:29:38 -0400 (EDT) Date: Mon, 16 Mar 2009 16:29:36 +0000 From: Mel Gorman Subject: Re: [PATCH 18/35] Do not disable interrupts in free_page_mlock() Message-ID: <20090316162936.GI24293@csn.ul.ie> References: <1237196790-7268-1-git-send-email-mel@csn.ul.ie> <1237196790-7268-19-git-send-email-mel@csn.ul.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org To: Christoph Lameter Cc: Linux Memory Management List , Pekka Enberg , Rik van Riel , KOSAKI Motohiro , Johannes Weiner , Nick Piggin , Linux Kernel Mailing List , Lin Ming , Zhang Yanmin , Peter Zijlstra List-ID: On Mon, Mar 16, 2009 at 12:05:53PM -0400, Christoph Lameter wrote: > On Mon, 16 Mar 2009, Mel Gorman wrote: > > > @@ -570,6 +570,8 @@ static void __free_pages_ok(struct page *page, unsigned int order) > > kernel_map_pages(page, 1 << order, 0); > > > > local_irq_save(flags); > > + if (clearMlocked) > > + free_page_mlock(page); > > __count_vm_events(PGFREE, 1 << order); > > free_one_page(page_zone(page), page, order, > > get_pageblock_migratetype(page)); > > Add an unlikely(clearMblocked) here? > I wasn't sure at the time of writing how likely the case really is but it makes sense that mlocked() pages are rarely freed. On reflection though, it makes sense to mark this unlikely(). > > @@ -1036,6 +1039,9 @@ static void free_hot_cold_page(struct page *page, int cold) > > pcp = &zone_pcp(zone, get_cpu())->pcp; > > local_irq_save(flags); > > __count_vm_event(PGFREE); > > + if (clearMlocked) > > + free_page_mlock(page); > > + > > if (cold) > > list_add_tail(&page->lru, &pcp->list); > > else > > > > Same here also make sure tha the __count_vm_events(PGFREE) comes after the > free_pages_mlock() to preserve symmetry with __free_pages_ok() and maybe > allow the compiler to do CSE between two invocations of > __count_vm_events(). > Whatever about the latter reasoning about CSE, the symmetry makes sense. I've made the change. Thanks -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org