[PATCH] Point the UNEVICTABLE_LRU config option at the documentation

[PATCH] Point the UNEVICTABLE_LRU config option at the documentation

[David Howells]

Point the UNEVICTABLE_LRU config option at the documentation describing the
option.

Signed-off-by: David Howells <dhowells@redhat.com>
---

 mm/Kconfig |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)


diff --git a/mm/Kconfig b/mm/Kconfig
index b53427a..57971d2 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -213,6 +213,8 @@ config UNEVICTABLE_LRU
 	  will use one page flag and increase the code size a little,
 	  say Y unless you know what you are doing.
 
+	  See Documentation/vm/unevictable-lru.txt for more information.
+
 config HAVE_MLOCK
 	bool
 	default y if MMU=y

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] Point the UNEVICTABLE_LRU config option at the documentation

[Christoph Hellwig]

On Mon, Mar 16, 2009 at 10:59:45AM +0000, David Howells wrote:
> Point the UNEVICTABLE_LRU config option at the documentation describing the
> option.

Didn't we decide a while ago that the option is pointless and the code
should always be enabled?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] Point the UNEVICTABLE_LRU config option at the documentation

[KOSAKI Motohiro]

> On Mon, Mar 16, 2009 at 10:59:45AM +0000, David Howells wrote:
> > Point the UNEVICTABLE_LRU config option at the documentation describing the
> > option.
> 
> Didn't we decide a while ago that the option is pointless and the code
> should always be enabled?

Yeah.
CONFIG_UNEVICTABLE_LRU lost existing reason by David's good patch recently.

if nobody of nommu user post bug report in .30 age, I plan to remove
this config option at .31 age.

his patch is really really good job.



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] Point the UNEVICTABLE_LRU config option at the documentation

[Minchan Kim]

size vmlinux
   text	   data	    bss	    dec	    hex	filename
6232681	 747665	 708608	7688954	 7552fa	vmlinux

size vmlinux.unevictable
   text	   data	    bss	    dec	    hex	filename
6239404	 747985	 708608	7695997	 756e7d	vmlinux.unevictable

It almost increases about 7K.
Many embedded guys always have a concern about size although it is very small.
It's important about embedded but may not be about server.

In addition, CONFIG_UNEVICTABLE_LRU feature don't have a big impact in
embedded machines which have a very small ram.
I guess many embedded guys will not use this feature.

So, I don't want to remove this configurable option.
Lets not add useless size bloat in embedded system.


On Mon, Mar 16, 2009 at 9:22 PM, KOSAKI Motohiro
<kosaki.motohiro@jp.fujitsu.com> wrote:
>> On Mon, Mar 16, 2009 at 10:59:45AM +0000, David Howells wrote:
>> > Point the UNEVICTABLE_LRU config option at the documentation describing the
>> > option.
>>
>> Didn't we decide a while ago that the option is pointless and the code
>> should always be enabled?
>
> Yeah.
> CONFIG_UNEVICTABLE_LRU lost existing reason by David's good patch recently.
>
> if nobody of nommu user post bug report in .30 age, I plan to remove
> this config option at .31 age.
>
> his patch is really really good job.
>
>
>
>



-- 
Kinds regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] Point the UNEVICTABLE_LRU config option at the documentation

[KOSAKI Motohiro]

2009/3/16 Minchan Kim <minchan.kim@gmail.com>:
> size vmlinux
>   text    data     bss     dec     hex filename
> 6232681  747665  708608 7688954  7552fa vmlinux
>
> size vmlinux.unevictable
>   text    data     bss     dec     hex filename
> 6239404  747985  708608 7695997  756e7d vmlinux.unevictable
>
> It almost increases about 7K.
> Many embedded guys always have a concern about size although it is very small.
> It's important about embedded but may not be about server.

Thanks good report.
this is unintetional size to me. I'll digg it later.

Thanks!


-- kosaki


>
> In addition, CONFIG_UNEVICTABLE_LRU feature don't have a big impact in
> embedded machines which have a very small ram.
> I guess many embedded guys will not use this feature.
>
> So, I don't want to remove this configurable option.
> Lets not add useless size bloat in embedded system.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>