From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
chris.mason@oracle.com, david@fromorbit.com, npiggin@suse.de,
linux-mm@kvack.org
Subject: Re: [PATCH 2/7] writeback: switch to per-bdi threads for flushing data
Date: Mon, 16 Mar 2009 06:22:53 -0400 [thread overview]
Message-ID: <20090316102253.GB9510@infradead.org> (raw)
In-Reply-To: <1236868428-20408-3-git-send-email-jens.axboe@oracle.com>
On Thu, Mar 12, 2009 at 03:33:43PM +0100, Jens Axboe wrote:
> +static void bdi_kupdated(struct backing_dev_info *bdi)
> +{
> + long nr_to_write;
> + struct writeback_control wbc = {
> + .bdi = bdi,
> + .sync_mode = WB_SYNC_NONE,
> + .nr_to_write = 0,
> + .for_kupdate = 1,
> + .range_cyclic = 1,
> + };
> +
> + sync_supers();
Not directly related to your patch, but can someone explain WTF
sync_supers is doing here or in the old kupdated? We're writing back
dirty pages from the VM, and for some reason we try to also write back
superblocks. This doesn't really make any sense.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next parent reply other threads:[~2009-03-16 10:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1236868428-20408-1-git-send-email-jens.axboe@oracle.com>
[not found] ` <1236868428-20408-3-git-send-email-jens.axboe@oracle.com>
2009-03-16 10:22 ` Christoph Hellwig [this message]
2009-03-16 13:30 ` Chris Mason
2009-03-16 13:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090316102253.GB9510@infradead.org \
--to=hch@infradead.org \
--cc=chris.mason@oracle.com \
--cc=david@fromorbit.com \
--cc=jens.axboe@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox