Re: [PATCH 2/4] Memory controller soft limit interface (v5)

[Balbir Singh <balbir@linux.vnet.ibm.com>]

* Andrew Morton <akpm@linux-foundation.org> [2009-03-12 15:59:05]:

> On Thu, 12 Mar 2009 23:26:20 +0530
> Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> 
> > +/**
> > + * Get the difference between the usage and the soft limit
> > + * @cnt: The counter
> > + *
> > + * Returns 0 if usage is less than or equal to soft limit
> > + * The difference between usage and soft limit, otherwise.
> > + */
> > +static inline unsigned long long
> > +res_counter_soft_limit_excess(struct res_counter *cnt)
> > +{
> > +	unsigned long long excess;
> > +	unsigned long flags;
> > +
> > +	spin_lock_irqsave(&cnt->lock, flags);
> > +	if (cnt->usage <= cnt->soft_limit)
> > +		excess = 0;
> > +	else
> > +		excess = cnt->usage - cnt->soft_limit;
> > +	spin_unlock_irqrestore(&cnt->lock, flags);
> > +	return excess;
> > +}
> >
> > ...
> >  
> > +static inline bool res_counter_check_under_soft_limit(struct res_counter *cnt)
> > +{
> > +	bool ret;
> > +	unsigned long flags;
> > +
> > +	spin_lock_irqsave(&cnt->lock, flags);
> > +	ret = res_counter_soft_limit_check_locked(cnt);
> > +	spin_unlock_irqrestore(&cnt->lock, flags);
> > +	return ret;
> > +}
> >
> > ...
> >
> > +static inline int
> > +res_counter_set_soft_limit(struct res_counter *cnt,
> > +				unsigned long long soft_limit)
> > +{
> > +	unsigned long flags;
> > +
> > +	spin_lock_irqsave(&cnt->lock, flags);
> > +	cnt->soft_limit = soft_limit;
> > +	spin_unlock_irqrestore(&cnt->lock, flags);
> > +	return 0;
> > +}
> 
> These functions look too large to be inlined?
>

I'll send a patch to fix it and move them to res_counter.c 

-- 
	Balbir

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>