From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with SMTP id 97A2A6B003D for ; Wed, 11 Mar 2009 19:47:49 -0400 (EDT) Received: from m2.gw.fujitsu.co.jp ([10.0.50.72]) by fgwmail5.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id n2BNlkEg026371 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Thu, 12 Mar 2009 08:47:46 +0900 Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 3817545DE55 for ; Thu, 12 Mar 2009 08:47:46 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 1A23E45DE57 for ; Thu, 12 Mar 2009 08:47:46 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id F06111DB803C for ; Thu, 12 Mar 2009 08:47:45 +0900 (JST) Received: from ml13.s.css.fujitsu.com (ml13.s.css.fujitsu.com [10.249.87.103]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 78F881DB803B for ; Thu, 12 Mar 2009 08:47:45 +0900 (JST) Date: Thu, 12 Mar 2009 08:46:23 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH] use css id in swap cgroup for saving memory v5 Message-Id: <20090312084623.e98d80b9.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: References: <20090310100707.e0640b0b.nishimura@mxp.nes.nec.co.jp> <20090310160856.77deb5c3.akpm@linux-foundation.org> <20090311085326.403a211d.kamezawa.hiroyu@jp.fujitsu.com> <20090311094739.3123b05d.kamezawa.hiroyu@jp.fujitsu.com> <20090311120427.2467bd14.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Hugh Dickins Cc: nishimura@mxp.nes.nec.co.jp, Andrew Morton , linux-mm@kvack.org, balbir@linux.vnet.ibm.com, lizf@cn.fujitsu.com List-ID: On Wed, 11 Mar 2009 11:05:55 +0000 (GMT) Hugh Dickins wrote: > Sorry, you'd prefer my input on the rest, which I've not studied, but ... > > On Wed, 11 Mar 2009, KAMEZAWA Hiroyuki wrote: > ... > > > > @@ -432,7 +428,7 @@ int swap_cgroup_swapon(int type, unsigne > > > > printk(KERN_INFO > > "swap_cgroup: uses %ld bytes of vmalloc for pointer array space" > > - " and %ld bytes to hold mem_cgroup pointers on swap\n", > > + " and %ld bytes to hold mem_cgroup information per swap ents\n", > > array_size, length * PAGE_SIZE); > > printk(KERN_INFO > > "swap_cgroup can be disabled by noswapaccount boot option.\n"); > > ... I do get very irritated by all the screenspace these messages take > up every time I swapon. I can see that you're following a page_cgroup > precedent, one which never bothered me because it got buried in dmesg; > and most other people wouldn't be doing swapon very often, and wouldn't > be logging to a visible screen ... but is there any chance of putting an > approximation to this info in the CGROUP_MEM_RES_CTRL_SWAP Kconfig help > text and removing these runtime messages? How do other people feel? > Ok, will remove this. (in other patch.) > I'm also disappointed that we invented such a tortuously generic boot > option as "cgroup_disable=memory", then departed from it when the very > first extension "noswapaccount" was required. "cgroup_disable=swap"? > Probably too late. > Hmm, cgroup_disable=memory is option to disable memory cgroup and "memory" is the subsytem name of cgroup. But "swap" isn't. Just removing "noswapaccount" option is ok ? Anyway, there is config. Thanks, -Kame > Hugh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org