From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with SMTP id 77FD06B003D for ; Mon, 9 Mar 2009 23:43:40 -0400 (EDT) Received: from m3.gw.fujitsu.co.jp ([10.0.50.73]) by fgwmail5.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id n2A3hbgq014435 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Tue, 10 Mar 2009 12:43:38 +0900 Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id CB08B45DD7E for ; Tue, 10 Mar 2009 12:43:37 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id A229445DD7D for ; Tue, 10 Mar 2009 12:43:37 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 83313E08002 for ; Tue, 10 Mar 2009 12:43:37 +0900 (JST) Received: from m106.s.css.fujitsu.com (m106.s.css.fujitsu.com [10.249.87.106]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 306781DB8044 for ; Tue, 10 Mar 2009 12:43:37 +0900 (JST) Date: Tue, 10 Mar 2009 12:42:15 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [BUGFIX][PATCH] memcg: charge swapcache to proper memcg Message-Id: <20090310124215.87437b80.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20090310121856.93cd2786.nishimura@mxp.nes.nec.co.jp> References: <20090310100707.e0640b0b.nishimura@mxp.nes.nec.co.jp> <20090310113502.d272fc2a.kamezawa.hiroyu@jp.fujitsu.com> <20090310121856.93cd2786.nishimura@mxp.nes.nec.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Daisuke Nishimura Cc: Andrew Morton , linux-mm , Balbir Singh , Li Zefan , Hugh Dickins List-ID: On Tue, 10 Mar 2009 12:18:56 +0900 Daisuke Nishimura wrote: > On Tue, 10 Mar 2009 11:35:02 +0900, KAMEZAWA Hiroyuki wrote: > > On Tue, 10 Mar 2009 10:07:07 +0900 > > Daisuke Nishimura wrote: > > > > > From: Daisuke Nishimura > > > > > > memcg_test.txt says at 4.1: > > > > > > This swap-in is one of the most complicated work. In do_swap_page(), > > > following events occur when pte is unchanged. > > > > > > (1) the page (SwapCache) is looked up. > > > (2) lock_page() > > > (3) try_charge_swapin() > > > (4) reuse_swap_page() (may call delete_swap_cache()) > > > (5) commit_charge_swapin() > > > (6) swap_free(). > > > > > > Considering following situation for example. > > > > > > (A) The page has not been charged before (2) and reuse_swap_page() > > > doesn't call delete_from_swap_cache(). > > > (B) The page has not been charged before (2) and reuse_swap_page() > > > calls delete_from_swap_cache(). > > > (C) The page has been charged before (2) and reuse_swap_page() doesn't > > > call delete_from_swap_cache(). > > > (D) The page has been charged before (2) and reuse_swap_page() calls > > > delete_from_swap_cache(). > > > > > > memory.usage/memsw.usage changes to this page/swp_entry will be > > > Case (A) (B) (C) (D) > > > Event > > > Before (2) 0/ 1 0/ 1 1/ 1 1/ 1 > > > =========================================== > > > (3) +1/+1 +1/+1 +1/+1 +1/+1 > > > (4) - 0/ 0 - -1/ 0 > > > (5) 0/-1 0/ 0 -1/-1 0/ 0 > > > (6) - 0/-1 - 0/-1 > > > =========================================== > > > Result 1/ 1 1/ 1 1/ 1 1/ 1 > > > > > > In any cases, charges to this page should be 1/ 1. > > > > > > In case of (D), mem_cgroup_try_get_from_swapcache() returns NULL > > > (because lookup_swap_cgroup() returns NULL), so "+1/+1" at (3) means > > > charges to the memcg("foo") to which the "current" belongs. > > > > Hmm...in try_charge_swapin(), if !PageSwapCache(), > > it seems no charges and returns NULL...(means commit will not occur.) > > Could you clarify ? > > > I'm saying about PageSwapCache() case. > IIUC, swapcache which has been unmapped but has not been removed from > swapcache yet on swap-out path (so not uncharged yet) can go through > this (D) path. > Ok, then, lookup_swap_cgroup() can return NULL if swap_cgroup is cleared. i.e. PageCgroupUsed(pc) == true. Thank you for your continuous effort! Acked-by: KAMEZAWA Hiroyuki > > Thanks, > Daisuke Nishimura. > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org