From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with ESMTP id E24256B00D2 for ; Mon, 9 Mar 2009 04:48:53 -0400 (EDT) Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by e28smtp06.in.ibm.com (8.13.1/8.13.1) with ESMTP id n298mm0m020363 for ; Mon, 9 Mar 2009 14:18:48 +0530 Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n298jeRc1335430 for ; Mon, 9 Mar 2009 14:15:40 +0530 Received: from d28av04.in.ibm.com (loopback [127.0.0.1]) by d28av04.in.ibm.com (8.13.1/8.13.3) with ESMTP id n298mlnf010727 for ; Mon, 9 Mar 2009 19:48:48 +1100 Date: Mon, 9 Mar 2009 14:18:44 +0530 From: Balbir Singh Subject: Re: [RFC][PATCH 1/4] memcg: add softlimit interface and utilitiy function. Message-ID: <20090309084844.GI24321@balbir.in.ibm.com> Reply-To: balbir@linux.vnet.ibm.com References: <20090309163745.5e3805ba.kamezawa.hiroyu@jp.fujitsu.com> <20090309163907.a3cee183.kamezawa.hiroyu@jp.fujitsu.com> <20090309074449.GH24321@balbir.in.ibm.com> <20090309165507.9f57ad41.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20090309165507.9f57ad41.kamezawa.hiroyu@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , "nishimura@mxp.nes.nec.co.jp" , "kosaki.motohiro@jp.fujitsu.com" List-ID: * KAMEZAWA Hiroyuki [2009-03-09 16:55:07]: > On Mon, 9 Mar 2009 13:14:49 +0530 > Balbir Singh wrote: > > > * KAMEZAWA Hiroyuki [2009-03-09 16:39:07]: > > > > > From: KAMEZAWA Hiroyuki > > > Adds an interface for defining sotlimit per memcg. (no handler in this patch.) > > > softlimit.priority and queue for softlimit is added in the next patch. > > > > > > > > > Changelog v1->v2: > > > - For refactoring, divided a patch into 2 part and this patch just > > > involves memory.softlimit interface. > > > - Removed governor-detect routine, it was buggy in design. > > > > > > Signed-off-by: KAMEZAWA Hiroyuki > > > --- > > > mm/memcontrol.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++++++++++-- > > > 1 file changed, 60 insertions(+), 2 deletions(-) > > > > > > This patch breaks the semantics of resource counters. We would like to > > use resource counters to track all overhead. I've refined my tracking > > to an extent that the overhead does not show up at all, unless soft > > limits kick in. I oppose keeping soft limits outside of resource > > counters. > > Hmm, them, moving mem->softlimit to res->softlimit is ok ? > > If no more "branch" to res_counter_charge/uncharge(), moving this to > res_counter is ok to me. > There is a branch, but the additional excessive checks are gone. It should be possible to reduce the overhead to comparisons though. -- Balbir -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org