From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id 3EA416B009A for ; Mon, 23 Feb 2009 06:44:23 -0500 (EST) Date: Mon, 23 Feb 2009 11:44:19 +0000 From: Mel Gorman Subject: Re: [PATCH 13/20] Inline buffered_rmqueue() Message-ID: <20090223114419.GE6740@csn.ul.ie> References: <1235344649-18265-1-git-send-email-mel@csn.ul.ie> <1235344649-18265-14-git-send-email-mel@csn.ul.ie> <84144f020902222324i38de9a63hd112b90742c2ca8c@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <84144f020902222324i38de9a63hd112b90742c2ca8c@mail.gmail.com> Sender: owner-linux-mm@kvack.org To: Pekka Enberg Cc: Linux Memory Management List , Rik van Riel , KOSAKI Motohiro , Christoph Lameter , Johannes Weiner , Nick Piggin , Linux Kernel Mailing List , Lin Ming , Zhang Yanmin List-ID: On Mon, Feb 23, 2009 at 09:24:19AM +0200, Pekka Enberg wrote: > On Mon, Feb 23, 2009 at 1:17 AM, Mel Gorman wrote: > > buffered_rmqueue() is in the fast path so inline it. This incurs text > > bloat as there is now a copy in the fast and slow paths but the cost of > > the function call was noticeable in profiles of the fast path. > > > > Signed-off-by: Mel Gorman > > --- > > mm/page_alloc.c | 3 ++- > > 1 files changed, 2 insertions(+), 1 deletions(-) > > > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index d8a6828..2383147 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -1080,7 +1080,8 @@ void split_page(struct page *page, unsigned int order) > > * we cheat by calling it from here, in the order > 0 path. Saves a branch > > * or two. > > */ > > -static struct page *buffered_rmqueue(struct zone *preferred_zone, > > +static inline > > +struct page *buffered_rmqueue(struct zone *preferred_zone, > > struct zone *zone, int order, gfp_t gfp_flags, > > int migratetype) > > { > > I'm not sure if this is changed now but at least in the past, you had > to use __always_inline to force GCC to do the inlining for all > configurations. > Hmm, as there is only one call-site, I would expect gcc to inline it. I can force it though. Thanks -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org