Re: [patch 2/2 v2] vmscan: clip swap_cluster_max in shrink_all_memory()

[KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>]

> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> Reviewed-by: MinChan Kim <minchan.kim@gmail.com>
> Acked-by: Nigel Cunningham <ncunningham@crca.org.au>
> Acked-by: "Rafael J. Wysocki" <rjw@sisk.pl>
> Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Cc: Rik van Riel <riel@redhat.com>
> 
> 
> ---
>  mm/vmscan.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 172e394..ed329c4 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -2114,7 +2114,6 @@ unsigned long shrink_all_memory(unsigned long nr_pages)
>  	struct scan_control sc = {
>  		.gfp_mask = GFP_KERNEL,
>  		.may_unmap = 0,
> -		.swap_cluster_max = nr_pages,
>  		.may_writepage = 1,
>  		.isolate_pages = isolate_pages_global,
>  	};
> @@ -2156,6 +2155,7 @@ unsigned long shrink_all_memory(unsigned long nr_pages)
>  			unsigned long nr_to_scan = nr_pages - sc.nr_reclaimed;
>  
>  			sc.nr_scanned = 0;
> +			sc.swap_cluster_max = nr_to_scan;
>  			shrink_all_zones(nr_to_scan, prio, pass, &sc);
>  			if (sc.nr_reclaimed >= nr_pages) 
>  				goto out;

good catch.

	Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>