[PATCH] memcg: remove mem_cgroup_reclaim_imbalance() perfectly

[PATCH] memcg: remove mem_cgroup_reclaim_imbalance() perfectly

[KOSAKI Motohiro]

commit 4f98a2fee8acdb4ac84545df98cccecfd130f8db (vmscan: 
split LRU lists into anon & file sets) remove mem_cgroup_reclaim_imbalance().

but it isn't enough.
memcontrol.h header file still have legacy parts.


Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
---
 include/linux/memcontrol.h |    6 ------
 1 file changed, 6 deletions(-)

Index: b/include/linux/memcontrol.h
===================================================================
--- a/include/linux/memcontrol.h
+++ b/include/linux/memcontrol.h
@@ -88,7 +88,6 @@ extern void mem_cgroup_end_migration(str
 /*
  * For memory reclaim.
  */
-extern long mem_cgroup_reclaim_imbalance(struct mem_cgroup *mem);
 int mem_cgroup_inactive_anon_is_low(struct mem_cgroup *memcg);
 unsigned long mem_cgroup_zone_nr_pages(struct mem_cgroup *memcg,
 				       struct zone *zone,
@@ -202,11 +201,6 @@ static inline void mem_cgroup_end_migrat
 {
 }
 
-static inline int mem_cgroup_reclaim_imbalance(struct mem_cgroup *mem)
-{
-	return 0;
-}
-
 static inline bool mem_cgroup_disabled(void)
 {
 	return true;


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] memcg: remove mem_cgroup_reclaim_imbalance() perfectly

[Balbir Singh]

* KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> [2009-02-10 18:50:39]:

> 
> commit 4f98a2fee8acdb4ac84545df98cccecfd130f8db (vmscan: 
> split LRU lists into anon & file sets) remove mem_cgroup_reclaim_imbalance().
> 
> but it isn't enough.
> memcontrol.h header file still have legacy parts.
> 
> 
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
> ---
>  include/linux/memcontrol.h |    6 ------
>  1 file changed, 6 deletions(-)
>

The calc_mapped_ratio prototype should also be removed from this file. 

-- 
	Balbir

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] memcg: remove mem_cgroup_reclaim_imbalance() perfectly

[KOSAKI Motohiro]

> * KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> [2009-02-10 18:50:39]:
> 
> > 
> > commit 4f98a2fee8acdb4ac84545df98cccecfd130f8db (vmscan: 
> > split LRU lists into anon & file sets) remove mem_cgroup_reclaim_imbalance().
> > 
> > but it isn't enough.
> > memcontrol.h header file still have legacy parts.
> > 
> > 
> > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> > Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
> > ---
> >  include/linux/memcontrol.h |    6 ------
> >  1 file changed, 6 deletions(-)
> >
> 
> The calc_mapped_ratio prototype should also be removed from this file. 

ok, thanks.
I'll do that soon.



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] memcg: remove mem_cgroup_reclaim_imbalance() perfectly

[KOSAKI Motohiro]

Hi Balbir,

> > * KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> [2009-02-10 18:50:39]:
> > 
> > > 
> > > commit 4f98a2fee8acdb4ac84545df98cccecfd130f8db (vmscan: 
> > > split LRU lists into anon & file sets) remove mem_cgroup_reclaim_imbalance().
> > > 
> > > but it isn't enough.
> > > memcontrol.h header file still have legacy parts.
> > > 
> > > 
> > > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> > > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> > > Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
> > > ---
> > >  include/linux/memcontrol.h |    6 ------
> > >  1 file changed, 6 deletions(-)
> > >
> > 
> > The calc_mapped_ratio prototype should also be removed from this file. 
> 
> ok, thanks.
> I'll do that soon.

I fixed this by "memcg: remove mem_cgroup_calc_mapped_ratio() take2".
Then, We don't need to change this patch.

Thanks!



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>