Re: [PATCH] mm: remove zone->prev_prioriy

[Johannes Weiner <hannes@cmpxchg.org>]

On Tue, Feb 10, 2009 at 06:42:30PM +0900, KOSAKI Motohiro wrote:
> 
> KAMEZAWA Hiroyuki sugessted to remove zone->prev_priority.
> it's because Split-LRU VM doesn't use this parameter at all.
> 
> 
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> ---
>  include/linux/memcontrol.h |   27 -------------------------
>  include/linux/mmzone.h     |   15 --------------
>  mm/memcontrol.c            |   31 -----------------------------
>  mm/page_alloc.c            |    2 -
>  mm/vmscan.c                |   48 ++-------------------------------------------
>  mm/vmstat.c                |    2 -
>  6 files changed, 3 insertions(+), 122 deletions(-)

> Index: b/include/linux/memcontrol.h
> ===================================================================
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -88,14 +88,7 @@ extern void mem_cgroup_end_migration(str
>  /*
>   * For memory reclaim.
>   */
> -extern int mem_cgroup_calc_mapped_ratio(struct mem_cgroup *mem);

This bit crept in from the next patch, I think.

>  extern long mem_cgroup_reclaim_imbalance(struct mem_cgroup *mem);
> -
> -extern int mem_cgroup_get_reclaim_priority(struct mem_cgroup *mem);
> -extern void mem_cgroup_note_reclaim_priority(struct mem_cgroup *mem,
> -							int priority);
> -extern void mem_cgroup_record_reclaim_priority(struct mem_cgroup *mem,
> -							int priority);
>  int mem_cgroup_inactive_anon_is_low(struct mem_cgroup *memcg);
>  unsigned long mem_cgroup_zone_nr_pages(struct mem_cgroup *memcg,
>  				       struct zone *zone,
> @@ -209,31 +202,11 @@ static inline void mem_cgroup_end_migrat
>  {
>  }
>  
> -static inline int mem_cgroup_calc_mapped_ratio(struct mem_cgroup *mem)
> -{
> -	return 0;
> -}
> -

:)

Looks good to me otherwise.

Reviewed-by: Johannes Weiner <hannes@cmpxchg.org>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>