From: Ravikiran G Thirumalai <kiran@scalex86.org>
To: wli@movementarian.org
Cc: Mel Gorman <mel@csn.ul.ie>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
shai@scalex86.org
Subject: Re: [patch] mm: Fix SHM_HUGETLB to work with users in hugetlb_shm_group
Date: Thu, 5 Feb 2009 17:28:58 -0800 [thread overview]
Message-ID: <20090206012858.GB8946@localdomain> (raw)
In-Reply-To: <20090205233257.GH10229@movementarian.org>
On Thu, Feb 05, 2009 at 06:32:57PM -0500, wli@movementarian.org wrote:
>On Thu, Feb 05, 2009 at 11:08:51AM -0800, Ravikiran G Thirumalai wrote:
>> I totally agree. In fact yesterday I was thinking of resending
>> this patch to not account for shm memory when a user is not
>> validated against rlimits (when he has CAP_IPC_LOCK or if he
>> belongs to the sysctl_hugetlb_shm_group).
>> As I see it there must be two parts:
>> 1. Free ticket to CAP_IPC_LOCK and users belonging to
>> sysctl_hugetlb_shm_group
>> 2. Patch to have users not having CAP_IPC_LOCK or
>> sysctl_hugetlb_shm_group to check against memlock
>> rlimits, and account it. Also mark this deprecated in
>> feature-removal-schedule.txt
>> Would this be OK?
>
>This is the ideal scenario, except I thought the rlimit was destined
>to replace the other methods, not vice-versa. I don't really mind
>going this way, but maybe we should check in with the rlimit authors.
RLIMIT_MEMLOCK for SHM_HUGETLB seems bad and unrelated! And as Mel rightly
pointed out, currently rlimits are checked for hugetlb shm but not for
hugetlb mmaps. Unless whoever authored the rlimit limitation comes forward
with a good explanation, I think it should be deprecated.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-02-06 1:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-04 22:04 Cannot use SHM_HUGETLB as a regular user Ravikiran G Thirumalai
2009-02-04 22:11 ` wli
2009-02-05 0:41 ` [patch] mm: Fix SHM_HUGETLB to work with users in hugetlb_shm_group Ravikiran G Thirumalai
2009-02-05 2:03 ` KOSAKI Motohiro
2009-02-05 17:06 ` Nishanth Aravamudan
2009-02-05 13:25 ` Mel Gorman
2009-02-05 19:08 ` Ravikiran G Thirumalai
2009-02-05 23:32 ` wli
2009-02-06 1:28 ` Ravikiran G Thirumalai [this message]
2009-02-10 11:09 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090206012858.GB8946@localdomain \
--to=kiran@scalex86.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=shai@scalex86.org \
--cc=wli@movementarian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox