From: Andrea Arcangeli <aarcange@redhat.com>
To: Robin Holt <holt@sgi.com>
Cc: linux-mm@kvack.org, Nick Piggin <npiggin@suse.de>,
Christoph Lameter <cl@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [Patch] mmu_notifiers destroyed by __mmu_notifier_release() retain extra mm_count.
Date: Thu, 5 Feb 2009 22:20:58 +0100 [thread overview]
Message-ID: <20090205212058.GK14011@random.random> (raw)
In-Reply-To: <20090205172303.GB8559@sgi.com>
On Thu, Feb 05, 2009 at 11:23:03AM -0600, Robin Holt wrote:
>
> An application relying upon mmu_notifier_release for teardown of the
> mmu_notifiers will leak mm_structs. At the do_mmu_notifier_register
> increments mm_count, but __mmu_notifier_release() does not decrement it.
Sure agreed, thanks! This got unnoticed this long because KVM uses the
unregister method instead of the self-disarming ->release and I guess
your systems have quite some ram so it'd take a while for the memleak
to trigger.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-02-05 21:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 17:23 Robin Holt
2009-02-05 19:30 ` Christoph Lameter
2009-02-05 20:02 ` Robin Holt
2009-02-05 23:54 ` Christoph Lameter
2009-02-06 1:38 ` Andrea Arcangeli
2009-02-06 1:44 ` Andrea Arcangeli
2009-02-06 12:58 ` Robin Holt
2009-02-06 16:56 ` Andrea Arcangeli
2009-02-05 21:20 ` Andrea Arcangeli [this message]
2009-02-05 22:25 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090205212058.GK14011@random.random \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox